-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-release-1.28] fix: undefined instance state on provisioning state failed #7756
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash |
@comtalyst, The test case |
@@ -19,26 +19,12 @@ package azure | |||
import ( | |||
"fmt" | |||
"testing" | |||
"time" | |||
|
|||
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-08-01/compute" | |||
"github.com/golang/mock/gomock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gives the following error: github.com/golang/mock/gomock" imported and not used
so we have to remove the "github.com/golang/mock/gomock" from the import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shubham82 Do you know if there is a way to edit this branch without creating a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@comtalyst, IMO the maintainers of this repo have the permission to update the PR. IIRC, @x13n updated one of this Kind of PR.
@x13n could you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I was able to add a commit, the code should build now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @x13n, for fixing it.
/lgtm |
57c72c7
into
kubernetes:cluster-autoscaler-release-1.28
This is an automated cherry-pick of #7750
/assign comtalyst