Revert https://github.com/kubernetes/autoscaler/pull/7233

[x13n]

#7233 broke --leader-elect flag by introducing --lease-resource-name that is redundant with --leader-elect-resource-name

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #7668

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bugfix: --leader-elect flags can be specified again. Removed --lease-resource-name flag that was redundant with --leader-elect-resource-name.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[idebeijer]

Hi @x13n, I don't think this will fix #7668 as kube_flag.InitFlags() is still called before componentopts.BindLeaderElectionFlags(&leaderElection, pflag.CommandLine).

[idebeijer]

I quickly ran it locally, componentopts.BindLeaderElectionFlags() has to be called before kube_flag.InitFlags() in which the parsing of the flags happens. With #7233 reverted that should now be possible again, right?

I pushed the fix to PR #7761 for convenience but I'll close it if you add the fix to this PR.

[x13n]

Ah, you're right, of course. Let's merge your PR.

/close

[k8s-ci-robot]

@x13n: Closed this PR.

In response to this:

Ah, you're right, of course. Let's merge your PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.