VPA - Add golangci-lint to GitHub Actions #7800
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
|
/area vertical-pod-autoscaler |
| @@ -9,6 +9,8 @@ env: | |||
|
|
|||
| permissions: | |||
| contents: read | |||
| checks: write | |||
There was a problem hiding this comment.
Do you know why this is needed now? I swear this was working before?
There was a problem hiding this comment.
It's needed for annotations, see: https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#annotations
I guess pull-requests: read isn't needed though
It's only needed if only-new-issues is enabled in golangci-lint
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve Thanks! We can think about which linters to turn on, happy to see this going in! |
|
Thanks! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, gjtempleton, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
golangci-lint was added in #7797, this adds it to GitHub Actions to allow for PRs to be listed before needing a human to get manually run the lint
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: