Reduce error output on "kubectl delete" by adding "--ignore-not-found"

[guessi]

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

While doing ./hack/vpa-down.sh cleanup before deploy/re-deploy, there would have some error output as there's no resource to delete, by adding --ignore-not-found could greatly reduce those unnecessary output.

Which issue(s) this PR fixes:

Fixes n/a

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md

Reduce error output on "kubectl delete" by adding "--ignore-not-found"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guessi
Once this PR has been reviewed and has the lgtm label, please assign voelzmo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @guessi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[guessi]

After changed, it would still have some errors, but it's much lesser

% ./hack/vpa-down.sh
Deleting VPA Admission Controller certs.
Unregistering VPA admission controller webhook
Warning: deleting cluster-scoped resources, not scoped to the provided namespace
resource mapping not found for name: "verticalpodautoscalers.autoscaling.k8s.io" namespace: "" from "STDIN": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1"
ensure CRDs are installed first
resource mapping not found for name: "verticalpodautoscalercheckpoints.autoscaling.k8s.io" namespace: "" from "STDIN": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1"
ensure CRDs are installed first

the error here is simply because it try to do kubectl delete --ignore-not-found ./deploy/vpa-beta2-crd.yaml but it contains apiVersion: apiextensions.k8s.io/v1beta1 which might not available to the cluster (depends on what k8s version it is running with).

[guessi]

... no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1" ... could be easily cleaned by adding 2>/dev/null but I'm not sure if it is what we expected?

[adrianmoisey]

/ok-to-test

[adrianmoisey]

/remove-kind feature

[omerap12]

Thanks for your PR. a tiny nit from my side.

[omerap12]

nit: can we have the same pattern as we have above?

if [ ${ACTION} == delete ] ; then

[guessi]

It's trying to avoid shellcheck error, but yes, I can make the change.

[guessi]

Fixed, coding style should now aligned.

[omerap12]

Thanks! I know it's not ideal to omit the "", but I want to keep the coding style consistent. If you're up for it, feel free to adjust the above to follow a more optimal approach.

[guessi]

I'm totally fine for both, let's keep this PR simple - do one thing at a time :-)

[omerap12]

/lgtm