Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actuator force delete #7803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Uladzislau97
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables forceful node deletion, bypassing Pod Disruption Budgets (PDBs) when necessary for critical operations like emergency backups of node machine families.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Since we filter nodes for blocking pods before scaling down, and this change only applies to those filtered nodes that are explicitly allowed to be drained, the operation should be safe.

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 4, 2025
Copy link

linux-foundation-easycla bot commented Feb 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @Uladzislau97!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Uladzislau97
Once this PR has been reviewed and has the lgtm label, please assign aleksandra-malinowska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Uladzislau97. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer February 4, 2025 10:38
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler labels Feb 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from x13n February 4, 2025 10:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2025
@Uladzislau97 Uladzislau97 changed the title Actuator force delete Draft:Actuator force delete Feb 4, 2025
@Uladzislau97 Uladzislau97 marked this pull request as draft February 4, 2025 10:40
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@Uladzislau97 Uladzislau97 changed the title Draft:Actuator force delete Actuator force delete Feb 4, 2025
@Uladzislau97 Uladzislau97 force-pushed the actuator-force-delete branch from f4bd6d1 to f6267a5 Compare February 4, 2025 19:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 4, 2025
@Uladzislau97
Copy link
Author

Uladzislau97 commented Feb 4, 2025

/uncc @feiskyer
/cc @BigDarkClown

@Uladzislau97
Copy link
Author

/unassign @BigDarkClown

@Uladzislau97
Copy link
Author

/cc @BigDarkClown

@Uladzislau97
Copy link
Author

/uncc @feiskyer

@k8s-ci-robot k8s-ci-robot removed the request for review from feiskyer February 4, 2025 19:56
@Uladzislau97 Uladzislau97 marked this pull request as ready for review February 4, 2025 19:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@Uladzislau97
Copy link
Author

/uncc @aleksandra-malinowska
/uncc @feiskyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants