-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a panic in GetContainersResources() #7809
Conversation
The panic occurs when VPA is set to control only the resource Requests (rather than the default of both Requests and Limits).
Hi @rsgowman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @raywainman |
/ok-to-test |
/lgtm /approve Gahh, my bad on this one, thanks for the fix! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raywainman, rsgowman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The panic occurs when VPA is set to control only the resource Requests (rather than the default of both Requests and Limits).
Which issue(s) this PR fixes:
No issue filed.
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
n/a