-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better flags-docs creator #7811
Open
omerap12
wants to merge
13
commits into
kubernetes:master
Choose a base branch
from
omerap12:fix-vpa-flags-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4d947c7
Use better flags-docs creator
omerap12 1f8f2ad
Fixed typo
omerap12 0f3afeb
Add Boilerplate header
omerap12 dc77991
Removed type
omerap12 fe761bf
Removed type
omerap12 9fba59b
fixed bug in script
omerap12 e359469
wrapped flags
omerap12 66cf05c
special handling for --v flag
omerap12 05bd1fb
add more dashes
omerap12 71aafda
Remove date
omerap12 8d8e29e
removed unused script
omerap12 2a7d53f
re-trigger ci
omerap12 f4ee7f6
mentioned autogenerated from the default branch
omerap12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
#!/bin/bash | ||
|
||
# Copyright 2025 The Kubernetes Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
set -o errexit | ||
set -o nounset | ||
set -o pipefail | ||
|
||
SCRIPT_ROOT=$(realpath $(dirname "${BASH_SOURCE[0]}"))/.. | ||
TARGET_FILE="${SCRIPT_ROOT}/docs/flags.md" | ||
COMPONENTS=("admission-controller" "recommender" "updater") | ||
|
||
# Function to extract flags from a binary | ||
extract_flags() { | ||
local binary=$1 | ||
local component=$2 | ||
|
||
if [ ! -f "$binary" ]; then | ||
echo "Error: Binary not found for ${component} at ${binary}" | ||
return 1 | ||
fi | ||
|
||
echo "# What are the parameters to VPA ${component}?" | ||
echo "This document is auto-generated from the flag definitions in the VPA ${component} code." | ||
echo | ||
echo "| Flag | Default | Description |" | ||
echo "|---------|---------|-------------|" | ||
|
||
$binary --help 2>&1 | grep -E '^\s*-' | while read -r line; do | ||
if [[ $line == *"-v, --v Level"* ]]; then | ||
# Special handling for the -v, --v Level flag | ||
flag="v" | ||
default=$(echo "$line" | sed -n 's/.*default: \([0-9]\+\).*/\1/p') | ||
description="Set the log level verbosity" | ||
else | ||
flag=$(echo "$line" | awk '{print $1}' | sed 's/^-*//;s/=.*$//') | ||
default=$(echo "$line" | sed -n 's/.*default \([^)]*\).*/\1/p') | ||
description=$(echo "$line" | sed -E 's/^\s*-[^[:space:]]+ [^[:space:]]+ //;s/ \(default.*\)//') | ||
description=$(echo "$description" | sed -E "s/^--?${flag}[[:space:]]?//") | ||
fi | ||
|
||
echo "| \`--${flag}\` | ${default:-} | ${description} |" | ||
done | ||
echo | ||
} | ||
# Build components | ||
pushd "${SCRIPT_ROOT}" >/dev/null | ||
for component in "${COMPONENTS[@]}"; do | ||
echo "Building ${component}..." | ||
pushd "pkg/${component}" >/dev/null | ||
if ! go build -o ${component} ; then | ||
echo "Error: Failed to build ${component}" | ||
popd >/dev/null | ||
continue | ||
fi | ||
popd >/dev/null | ||
done | ||
popd >/dev/null | ||
|
||
# Generate combined flags documentation | ||
echo "Generating flags documentation..." | ||
{ | ||
echo "# Vertical Pod Autoscaler Flags" | ||
echo "This document contains the flags for all VPA components." | ||
echo | ||
|
||
for component in "${COMPONENTS[@]}"; do | ||
binary="${SCRIPT_ROOT}/pkg/${component}/${component}" | ||
if ! extract_flags "$binary" "$component" ; then | ||
echo "Error: Failed to extract flags for ${component}" | ||
fi | ||
done | ||
} > "${TARGET_FILE}" | ||
|
||
echo "VPA flags documentation has been generated in ${TARGET_FILE}" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it makes sense to mention that it's autogenerated from the default branch?
I could see someone reading the docs in master, assuming that a newly added flag will work for them in their release.
This makes me think that we should also consider how we're showing versioned docs when we release new versions of the VPA. But that's a discussion for a different thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can add this to the script. But a follow-up question - how can a user check if some feature is available in their current VPA version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's tough.
At the moment they can (in theory) browse the repo at the release branch for their current version. But that's something they need to figure out themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood.