-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skewer version to v0.0.19 (master) #7826
base: master
Are you sure you want to change the base?
Update skewer version to v0.0.19 (master) #7826
Conversation
Hi @rakechill. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm
@rakechill, please link to these PRs |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rakechill, tallaxes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@@ -52,6 +52,7 @@ require ( | |||
k8s.io/cloud-provider-gcp/providers v0.28.2 | |||
k8s.io/component-base v0.33.0-alpha.0 | |||
k8s.io/component-helpers v0.33.0-alpha.0 | |||
k8s.io/dynamic-resource-allocation v0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curios about what in this PR bumps it to required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran go mod vendor
which triggered this. Let me check to see why that might be. I was thinking it may be due to further development of this feature on master w/o re-running module requirements. Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which could also explain why 1.32 (where it's experimental) was unaffected: https://github.com/kubernetes/autoscaler/pull/7827/files
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates a dependency version: https://github.com/Azure/skewer/releases/tag/v0.0.19
Already done for 1.27-1.31 release branches. Will follow this up with updating on 1.32.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: