-
Notifications
You must be signed in to change notification settings - Fork 4.2k
updating the script to handle multi-line flag descriptions #8144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @aman4433! |
Hi @aman4433. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks for this, but I see some errors: Building updater...
Generating flags documentation...
awk: cmd. line:6: default = ""
awk: cmd. line:6: ^ syntax error
awk: cmd. line:6: default = ""
awk: cmd. line:6: ^ syntax error
awk: cmd. line:6: default = ""
awk: cmd. line:6: ^ syntax error |
f962725
to
960f4c2
Compare
It's fixed now! |
960f4c2
to
c03cdd4
Compare
looks very good to me. |
/lgtm |
/approve We just want to get another older PR into master before this PR lands. |
Sure @adrianmoisey, just let me know once the older PR is in, and I'll go ahead and rebase this one with those changes! |
With this 7992 merged can you please rebase and re-run the flag generation script? |
c03cdd4
to
0e2b7b0
Compare
This is a flake, can you make another empty commit just to trigger the tests again? |
0e2b7b0
to
83b370e
Compare
Great work @aman4433 , thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, aman4433, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! Looking forward to more contributions. |
What type of PR is this?
What this PR does / why we need it:
This PR enhances the
generate-flags.sh
script to handle flags with multi-line descriptions, specifically to address the case of--feature-gates
.Previously, such flags were either incorrectly parsed or excluded from the generated
flags.md
documentation due to their multi-line nature. This led to incomplete CLI documentation, which can cause confusion for users, especially when dealing with important features like in-place updates that are behind feature gates.With this update the script now properly captures and formats multi-line flag descriptions.
This ensures that all flags—including complex ones like --feature-gates—are accurately represented in the VPA component documentation.
Which issue(s) this PR fixes:
Fixes #8139
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: