-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Deprecate Auto some more #9073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Deprecate Auto some more #9073
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
0f35d99 to
78cfc6a
Compare
78cfc6a to
b800f46
Compare
iamzili
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
|
FYI: I was considering cherry-picking this for 1.5, however, since the Deprecation warning is now fixed, it means that if anyone consuming this as a library bumps a patch version, their linting may break, which feels more like a minor change to me. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Follow up to:
Autoin VPA #8426If updatePolicy isn't set, then this code causes the VPA to be set to "auto" mode.
Since auto is deprecated, we would prefer Recreate.
Also, for IDEs to mark something as deprecated, the comment block needs a newline above it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: