Decide which kong proxy port to use in ingress based on kong setting

[tomty89]

Coupling the ingress setting with which kong proxy port to use is not exactly logical in at least some scenarios. One example would be that TLS passthrough is not supported / enabled / desired (but TLS termination is).

Since the kong proxy http port needs to be enabled for it to be usable anyway, this change should not cause current setup that have TLS ingress disabled to break, while it should at the same time offer some extra flexibility (and compatibility, for e.g. "nginx/kubernetes-ingress", which apparently does not support the nginx.ingress.kubernetes.io/ssl-passthrough annotation).

It does break TLS passthrough setup that for some reason have http kong proxy enabled though.

/cc @hamadodene @floreks @maciaszczykm

Ref.: #9861 #9863

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tomty89 (23863a3)

[k8s-ci-robot]

@tomty89: GitHub didn't allow me to request PR reviews from the following users: hamadodene.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Coupling the ingress setting with which kong proxy port to use is not exactly logical in at least some scenarios. One example would be that TLS passthrough is not supported / enabled / desired (but TLS termination is).

Since the kong proxy http port needs to be enabled for it to be usable anyway, this change should not cause current setup that have TLS ingress disabled to break, while it should at the same time offer some extra flexibility (and compatibility, for e.g. "nginx/kubernetes-ingress", which apparently does not support the nginx.ingress.kubernetes.io/ssl-passthrough annotation).

It does break TLS passthrough setup that for some reason have http kong proxy enabled though.

/cc @hamadodene @floreks @maciaszczykm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomty89
Once this PR has been reviewed and has the lgtm label, please assign shu-mutou for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @tomty89!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[tomty89]

Hmm just noticed that @mrjoshuap filed a similar PR earlier already, albeit with a slightly different approach and extra polish for the annotations.

I'll leave this open and let you guys decide which one to merge. Close as you wish. :)

[mrjoshuap]

Yes indeed, @tomty89. I put in #10086 to accomodate my installation and have been maintaining my own fork... not ideal, but it works.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale