Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-647: Update apiserver tracing KEP to beta for 1.24 #3161

Merged
merged 1 commit into from
Jan 26, 2022
Merged

KEP-647: Update apiserver tracing KEP to beta for 1.24 #3161

merged 1 commit into from
Jan 26, 2022

Conversation

dashpole
Copy link
Contributor

Other comments:

/assign @ehashman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2022
ehashman
ehashman reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for Instrumentation, leaving PRR to @wojtek-t

@k8s-ci-robot k8s-ci-robot assigned wojtek-t and unassigned ehashman Jan 20, 2022
@ehashman
Copy link
Member

ehashman commented Jan 20, 2022 •
edited
Loading

/hold

to prevent premature merge from PRR

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
wojtek-t
wojtek-t reviewed Jan 24, 2022
View reviewed changes
keps/sig-instrumentation/647-apiserver-tracing/README.md Outdated

* **What specific metrics should inform a rollback?**

* API Server [SLOs](https://github.com/kubernetes/community/tree/master/sig-scalability/slos) are the signals that should guide a rollback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe explicitly link one of those two metrics:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L99-L124

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - how about increased number of errors maybe (timeouts come to my mind first)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link to those metrics. For errors, were you thinking of pointing to apiserver_request_post_timeout_total? Or something else?

keps/sig-instrumentation/647-apiserver-tracing/README.md Outdated
- Components exposing the metric:
- [ ] Other (treat as last resort)
- Details:
- OpenTelemetry does not currently expose metrics about the number of traces sent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a useful optional feature. Can you maybe open a feature request on the OT for doing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - can we somehow mitigate it on our side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-telemetry/opentelemetry-go#2547. I don't know of a way to work around it right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link this issue in the KEP too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@dashpole dashpole mentioned this pull request Jan 24, 2022
Open
wojtek-t
wojtek-t reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit - I will approve once fixed.

keps/sig-instrumentation/647-apiserver-tracing/README.md Outdated
- Components exposing the metric:
- [ ] Other (treat as last resort)
- Details:
- OpenTelemetry does not currently expose metrics about the number of traces sent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link this issue in the KEP too?

@wojtek-t
Copy link
Member

Thanks for pushing this @dashpole !

I'm so happy to see this effort progressing :)

/lgtm
/approve PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@wojtek-t
Copy link
Member

Cancelling hold given Elana`s lgtm from sig -instrumentation.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 24ef1ae into kubernetes:master Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman requested changes

@wojtek-t wojtek-t wojtek-t left review comments

@brancz brancz Awaiting requested review from brancz

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@dashpole @ehashman @wojtek-t @k8s-ci-robot