Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys #5205

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys #5205

wants to merge 3 commits into from

Conversation

mochizuki875
Copy link
Member

@mochizuki875 mochizuki875 commented Mar 14, 2025 •
edited
Loading

One-line PR description: Update KEP milestone v1.33 to v1.34 since the code change have not meet the v1.33 code freeze, and I've added the new feature gate for #129874 as discussed in kubernetes/kubernetes#129874 (comment).
Issue link: #3243
Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mochizuki875
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Huang-Wei March 14, 2025 05:33
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Mar 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2025
@mochizuki875
Copy link
Member Author

/cc @sanposhiho
/cc @alculquicondor
/cc @deads2k

@mochizuki875 mochizuki875 changed the title KEP-3243: Add the new feature gate for #129874 KEP-3243: Add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys Mar 14, 2025
@mochizuki875 mochizuki875 mentioned this pull request Mar 14, 2025
Open
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from 1a3dbd2 to 4e8004a Compare March 14, 2025 08:26
This was referenced Mar 17, 2025
Closed
Closed
@sanposhiho
Copy link
Member

/cc @macsko @dom4ha

@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko March 21, 2025 05:38
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from 4e8004a to 39ebbdc Compare March 21, 2025 08:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2025
@mochizuki875 mochizuki875 changed the title KEP-3243: Add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys Mar 21, 2025
@mochizuki875
Copy link
Member Author

I've merged #5214 into this change.

@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from b154ec0 to 8148d60 Compare March 24, 2025 06:10
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from 8148d60 to d91c6ff Compare March 24, 2025 06:33
@mochizuki875
Copy link
Member Author

@sanposhiho
Thank you for your comments.
I've addressed them while making minor adjustments.

macsko
macsko reviewed Apr 7, 2025
View reviewed changes
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the implementation history?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for letting me know.
I've updated.

enhancements/keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md

Line 1084 in c06d5c3

- 2025-04-07: Add a new feature flag `MatchLabelKeysInPodTopologySpreadSelectorMerge` and update milestone

keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md
We're going to change kube-scheduler to only concern `matchLabelKeys` from the default constraints at v1.34 for efficiency,
So, for a safe upgrade path from v1.33 to v1.34, kube-scheduler would handle not only `matchLabelKeys`
from the default constraints, but also all incoming pods during v1.34.
We're going to change kube-scheduler to only concern `matchLabelKeys` from the default constraints at v1.35 for efficiency,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, are we planning to make the MatchLabelKeysInPodTopologySpreadSelectorMerge GA in v1.35? Without this, we won't be able to change the kube-scheduler's code this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have not met the v1.33 lifecycle, I think every step should shift one version forward as below.

  • Merge this design change as beta and scheduler will handle all matchLabelKeys: v1.33 -> v1.34
  • Change scheduler to only concern matchLabelKeys from the default constraints: v1.34 -> v1.35
  • Change MatchLabelKeysInPodTopologySpread(including MatchLabelKeysInPodTopologySpreadSelectorMerge) to GA from beta: v1.35 -> v1.36

Therefore I think the change for scheduler was previously planned to take place during beta.
But if needed, we can change the plan for scheduler change from v1.35 to v1.36 to align with the GA of MatchLabelKeysInPodTopologySpreadSelectorMerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@macsko macsko macsko left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@deads2k deads2k Awaiting requested review from deads2k

@dom4ha dom4ha Awaiting requested review from dom4ha

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mochizuki875 @k8s-ci-robot @sanposhiho @macsko