Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COSI v1alpha2 feature addition: 1-to-many bucketaccess:bucket relationship design #5219

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

COSI v1alpha2 feature addition: 1-to-many bucketaccess:bucket relationship design #5219

wants to merge 2 commits into from

Conversation

BlaineEXE
Copy link

  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 26, 2025
@BlaineEXE BlaineEXE force-pushed the cosi-v1alpha2-additions branch 2 times, most recently from ad0836e to 78b8792 Compare March 26, 2025 21:44
@BlaineEXE
kep-1979: update base design to v1alpha2
586add2 
Update the COSI KEP's base design to v1alpha2. The primary purpose of
this work is to reshape the doc and spec to fix inconsistencies and
vestigial items, and fix the most glaring issues in the v1alpha1 spec.

COSI maintainers are planning follow-up items to add larger individual
features after this.

Notably, bucketInfo.json has been changed to individual secret fields
with COSI_<KEY>: <VALUE> format, as the JSON blob was flagged as a
problem by several v1alpha1 users.

Signed-off-by: Blaine Gardner <[email protected]>
@BlaineEXE
cosi: add 1:many access:bucket design to kep
d333b38 
Add support to the COSI KEP for a single BucketAccess to reference
multiple BucketClaims. This is a highly requested feature that allows
COSI to support legacy applications that don't support buckets with
independent users/accesses.

Signed-off-by: Blaine Gardner <[email protected]>
@BlaineEXE BlaineEXE force-pushed the cosi-v1alpha2-additions branch from 78b8792 to d333b38 Compare March 27, 2025 17:38
@BlaineEXE BlaineEXE mentioned this pull request Mar 28, 2025
Open
moonlight16
moonlight16 reviewed Mar 31, 2025
View reviewed changes
keps/sig-storage/1979-object-storage-support/README.md

These properties will be specified in the BucketRequest and follow the same pattern of events as Bucket creation. i.e. Bucket API object will be updated to reflect the properties set in BucketRequest, and then a controller will pick-up these changes and call the appropriate APIs to reflect them in the backend.
The COSI Controller will update the status field of the BucketClaim object accordingly based on the status field of the Bucket object to indicate the new snapshot is ready to be used or failed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"new snapshot"? do you mean "new bucket?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from commmenting on this PR while it is still in draft state. You're commenting on changes from a different PR, and I'd prefer this discussion not get overpolluted with comments before it's ready.

If you'd like to review, please focus here: #4599

@shanduur shanduur mentioned this pull request Apr 1, 2025
Open
8 tasks
@BlaineEXE BlaineEXE changed the title COSI v1alpha2 feature additions COSI v1alpha2 feature addition: 1-to-many bucketaccess:bucket relationship design Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonlight16 moonlight16 moonlight16 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlaineEXE @k8s-ci-robot @moonlight16