Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.29][go1.23] Build with go 1.23.6 #130196

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[release-1.29][go1.23] Build with go 1.23.6 #130196

merged 1 commit into from
Feb 20, 2025

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 15, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates release-1.29 branch to build with go 1.23

Requires kubernetes/release#3929 and promotion before this will pass CI

xref kubernetes/release#3650

Does this PR introduce a user-facing change?

Kubernetes 1.29 is now built with go 1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 15, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels Feb 15, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2025
@liggitt
Copy link
Member Author

liggitt commented Feb 15, 2025

still needs go-runner / builder / kube-cross images built

@liggitt
Copy link
Member Author

liggitt commented Feb 15, 2025

cc @dims @cpanato @MadhavJivrajani

@cpanato
Copy link
Member

cpanato commented Feb 18, 2025

/retest

2 similar comments
@liggitt
Copy link
Member Author

liggitt commented Feb 18, 2025

/retest

@cpanato
Copy link
Member

cpanato commented Feb 18, 2025

/retest

@liggitt
Copy link
Member Author

liggitt commented Feb 18, 2025

/test pull-kubernetes-cross

@cpanato
Copy link
Member

cpanato commented Feb 19, 2025

/retest

cpanato
cpanato approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3822bd8fd118809d85478c9bf9eba2b71e2192a0

@cpanato
Copy link
Member

cpanato commented Feb 19, 2025

cc @kubernetes/release-managers

/assign @saschagrunert

xmudrii
xmudrii approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 20, 2025
@xmudrii
Copy link
Member

xmudrii commented Feb 20, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Feb 20, 2025

Some additional discussion, we'll be proceeding with this one: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1740044600653219
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 70ffcfe into kubernetes:release-1.29 Feb 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @k8s-ci-robot @cpanato @xmudrii @saschagrunert