Skip to content

Automated cherry pick of #130503: Unhandled panic crash on rollout_history printer.PrintObj #131496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: release-1.33
Choose a base branch
from
Open

Automated cherry pick of #130503: Unhandled panic crash on rollout_history printer.PrintObj #131496

wants to merge 10 commits into from
+92 −2

Conversation

tahacodes
Copy link
Contributor

Cherry pick of #130503 on release-1.33.

#130503: Unhandled panic crash on rollout_history printer.PrintObj

For details on the cherry pick process, see the cherry pick requests page.

Fixed a panic issue related to kubectl revision history kubernetes/kubectl#1724

tahacodes added 10 commits April 27, 2025 10:37
@tahacodes
Change: Handling nil runtime.Object
303b28e 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Return only if there is error in rollout_history
191b858 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Return the unknown revision error directly in rollout_history.go
bb64a40 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Remove unintended newline
f201945 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Using go idiomatic way for checking if historyInfo[o.Revision…
a314f1e 
…] exists

Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Remove 'error:' from returned error message in rollout_histor…
ca7a12a 
…y.go

Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Check for printer.PrintObj returned err
eca69a2 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Add TestRolloutHistoryErrors test
66d53d1 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Simple typo fix on Complete() function description
19cf3e4 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes
Change: Checking for error on o.Complete in TestRolloutHistoryErrors
c0792bf 
Signed-off-by: Taha Farahani <tahacodes@proton.me>
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Apr 27, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tahacodes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 27, 2025
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Apr 27, 2025
@pacoxu
Copy link
Member

pacoxu commented Apr 27, 2025

/kind bug
/lgtm
/ok-to-test
/assign @soltysh

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 27, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02f3a0d3067e89b7eabac116a4713daedf6d77f5

@tahacodes
Copy link
Contributor Author

🤔
/retest

@ardaguclu
Copy link
Member

/triage accepted
/priority important-soon
/lgtm
/approve
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 28, 2025
@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2025
@ardaguclu
Copy link
Member

cc: @kubernetes/release-managers

soltysh
soltysh approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh, tahacodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Apr 29, 2025

@kubernetes/release-managers ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh

@ardaguclu ardaguclu

@mpuckett159 mpuckett159

Assignees

@soltysh soltysh

@pacoxu pacoxu

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Status: Needs Triage
[sig-release] Bug Triage
Status: No status
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tahacodes @k8s-ci-robot @pacoxu @ardaguclu @soltysh