-
Notifications
You must be signed in to change notification settings - Fork 5.1k
bootstrapper ipv6: plumb ip-family through kubeadm, kubelet and control-plane alias #22064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bootstrapper ipv6: plumb ip-family through kubeadm, kubelet and control-plane alias #22064
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kartikjoshi21 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kartikjoshi21. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
Logs: |
a1f0157 to
bf634c4
Compare
|
illume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 🎉
I added a few questions/notes.
bf634c4 to
4011bf3
Compare
|
@kartikjoshi21 note the merge conflicts |
7aa5069 to
39461d5
Compare
39461d5 to
6e93f40
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Make kubeadm configs IP-family aware:
for dual-stack so kubelet can advertise both families
bind address to 0.0.0.0:10249 (ipv4/dual) or [::]:10249 (ipv6-only)
Update kubelet/certs/bootstrapper:
(IPv4-only, IPv6-only, or both in dual-stack)
Make endpoints & kubeconfig IPv6 safe:
kubeconfig URLs (https://[::1]:8443)
Ensure core Services follow the chosen family:
desired ipFamilyPolicy + ipFamilies (SingleStack IPv4/IPv6, or
PreferDualStack [IPv4, IPv6])
Extend ServiceClusterIP() to handle comma-separated Service CIDRs and
prefer IPv4 when present, so dual-stack serviceSubnet values do not
break certificate generation.
Fixes: #8535
Refer to this for testing steps: #22064 (comment)
Tested and verified on: