replace mkisofs command with native xorriso commands #22097
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vtri950 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-ok-to-test
|
Hi @vtri950. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
| cp efi-part/EFI/BOOT/* root/EFI/BOOT/ | ||
| cp efiboot.img root/EFI/BOOT/ | ||
|
|
||
| mkisofs \ |
There was a problem hiding this comment.
this would break non fedora ones...how about add a logic that if it is Fedora then it should use a different command ?
There was a problem hiding this comment.
this would break non fedora ones
AI promised that this works also on Ubuntu 22.04.
There was a problem hiding this comment.
The package exists:
https://launchpad.net/ubuntu/jammy/+package/xorriso
There was a problem hiding this comment.
@vtri950 You need replace genisoimage with xorriso in the Ubuntu instructions:
https://minikube.sigs.k8s.io/docs/contrib/building/iso/
There was a problem hiding this comment.
There was a problem hiding this comment.
The change belongs to this PR.
Please also rebase this PR for testing. The current PR cannot be tested since master was broken when you created the PR.
|
/ok-to-build-iso |
|
Hi @vtri950, building a new ISO failed for Commit 70594ab |
|
@vtri950 please rebase this PR on current master for testing, and add the doc change from https://github.com/kubernetes/minikube/pull/22098/changes#diff-e20bcb0b65804fb7c7a6237fc16522f4d6b77514a62f2b6031a0fc2d59b501e8R62 |
|
Buildroot has support for iso9660 filesystem now, so you might not need the host scripts anymore. https://github.com/buildroot/buildroot/tree/master/fs/iso9660 And yes it uses xorriso, but it is built according to specifications. |
done |
|
@nirs is this pr good to merge or is there anything else that needs fixing? |
6 participants
When building the aarch64 ISO on Fedora, the build failed with:
xorriso : FAILURE : -as genisofs: Unrecognized option '-eltorito-platform=efi'On Fedora, the mkisofs command is actually implemented by xorriso using -as genisofs emulation mode. However, newer versions of xorriso don't support the -eltorito-platform=efi flag when emulating genisofs.
The Fix
I replaced the mkisofs command in post-image.sh with native xorriso commands.
fixes #22056