-
Notifications
You must be signed in to change notification settings - Fork 5.1k
site: Add GitHub Codespace instructions for Minikube #22102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: star3am The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
Hi @star3am. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@star3am I have an idea how about we add a new Tab here
|
|
@star3am how about the replace that Top Right Github Link with Open in Codespace that would be nicer I think. short and sweet
|
|
Hi @medyagh thank you for your suggestions, I appreciate that. I have updated my PR with the changes you requested. Thank you for the great project, have a happy festive season, best wishes! Riaan |
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for updating plz rebase, I also added something for the getting started page, make sure they dont conflict
And apt install cmake to avoid host-cmake
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.6 to 0.20.7. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Commits](google/go-containerregistry@v0.20.6...v0.20.7) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-version: 0.20.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ions-go/exporter/trace Bumps [github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases) - [Commits](GoogleCloudPlatform/opentelemetry-operations-go@detectors/gcp/v1.29.0...detectors/gcp/v1.30.0) --- updated-dependencies: - dependency-name: github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace dependency-version: 1.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
* Stop using packaging scripts for cri-dockerd The upstream packaging scripts do a lot of _insane_ things like start a docker container to run chown and use strange variables. Also restore the package version to normal, now that it is released. Should change the tarballs and hash for next time, with refactoring. * Updating ISO to v1.37.0-1766719468-22158 * rm extra line --------- Co-authored-by: minikube-bot <[email protected]> Co-authored-by: Medya Ghazizadeh <[email protected]> Co-authored-by: Medya Ghazizadeh <[email protected]>
* build: add cmake dependency to ISO build script * ci: Log CMake version and warn if below 3.20 during ISO build.
* ISO: upgrade crictl and crio to v1.35.0 * Kicbase: Update CRIO and CRICTL versions to v1.35 * auto updater: bump crictl version to v1.35.0 and extend version management to additional Prow integration scripts. * chore: update crictl version to v1.35.0 in Prow integration scripts * chore: remove empty line * switch crio-bin to download pre-built static binaries instead of building from source. * remove crio-shutdown service link (depricated) * update crio.service to match upstream with minikube flavor * build: Adjust crio and pinns binary installation source paths. * Updating ISO to v1.37.0-1766811082-22332 --------- Co-authored-by: minikube-bot <[email protected]>
* Kicbase/ISO: Update cni-plugins from v1.8.0 to v1.9.0 * Updating kicbase image to v0.0.48-1766884053-22351 * Updating ISO to v1.37.0-1766883634-22351
* Remove the cnitool package from iso Most networking only need the cni-plugins, not "cni" and cnitool: "Prior to release 0.7.0 the cni release also included a cnitool binary; as this is a developer tool we suggest you build it yourself." It has not been updated in years, so better to just remove it. * Updating ISO to v1.37.0-1766907750-22349 --------- Co-authored-by: minikube-bot <[email protected]> Co-authored-by: Medya Ghazizadeh <[email protected]>
…rnetes#22348) * Merge the patches directory separated by arch For some reason these were duplicated before. But they both had the same (obsolete) content? * Use patches for go.hash instead of copying It is now possible to provide hash files. Use that, instead of modifying buildroot. * Remove patches for obsolete package versions * Clean up the go.hash file to match upstream * Updating ISO to v1.37.0-1766949326-22348 --------- Co-authored-by: minikube-bot <[email protected]> Co-authored-by: Medya Ghazizadeh <[email protected]>
It was still using the old weird variables
Use the go compiler from buildroot for building packages, instead of installing a go compiler in the builder image. Make sure to build the host-go package and set up GOCACHE, before minikube packages have been fixed to use golang.mk
* Kicbase/ISO: Update containerd from 2.2.0 to 2.2.1 * Updating kicbase image to v0.0.48-1766979815-22353 * Updating ISO to v1.37.0-1766979747-22353
…#22356) * Install tar in the builder image to avoid host-tar Need a newer version of tar, then what is available in the package repositories for debian:12 and ubuntu:22.04 Build one in /usr/local/bin, while using the older tar in /usr/bin to unpack the source tarball for tar itself. * Improve the host-tar installation in the image Check the hash file and use nproc for make jobs, to make it more similar to the real tar package.
I have rebased, and pushed, let me know if you need anything else. |
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |


Added instructions for running Minikube in GitHub Codespaces and locally using Dev Containers.
Follow-up Documentation PR from this #21686