Skip to content

Conversation

@ThankaBharathi
Copy link

@ThankaBharathi ThankaBharathi commented Dec 26, 2025

This PR reintroduces Falco as an optional Minikube addon (DaemonSet-based),
enabled via minikube addons enable falco.

Falco was previously removed from the ISO during buildroot updates.
This approach avoids bundling Falco into the ISO while still allowing
users to experiment with runtime security locally.

The addon is marked as supported_os: linux, so it is intentionally
hidden on non-Linux hosts, which is expected behavior.

Fixes #22298

Example usage

# Enable Falco addon
minikube addons enable falco

# Check if Falco pod is running
kubectl get pods -n kube-system | grep falco

# View Falco logs
kubectl logs -n kube-system -l app=falco | head

Expected output:

falco is an experimental addon
Verifying addon image integrity …
The 'falco' addon is enabled
falco-7k9x2   1/1   Running   0   25s
Falco version: 0.38.1
Loading rules from file /etc/falco/falco_rules.yaml
Loading rules from file /etc/falco/falco_rules.local.yaml
Starting internal webserver, listening on port 8765

@k8s-ci-robot k8s-ci-robot requested review from medyagh and nirs December 26, 2025 07:13
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ThankaBharathi
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 26, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: ThankaBharathi / name: Thanka Bharathi (dbb37e4)

@k8s-ci-robot
Copy link
Contributor

Welcome @ThankaBharathi!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ThankaBharathi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 26, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 26, 2025
@medyagh
Copy link
Member

medyagh commented Dec 26, 2025

@ThankaBharathi would plz share an example output of using this addon in the PR description

@ThankaBharathi
Copy link
Author

Thanks for the suggestion! I’ve added an example usage section with expected output to the PR description.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Dec 29, 2025

I don't see why you would need this addon, and not just use helm:

https://falco.org/docs/getting-started/falco-kubernetes-quickstart/

Falco was previously removed from the ISO during buildroot updates.

Falco was not included in the ISO, only the kernel module was prebuilt.

@ThankaBharathi
Copy link
Author

Helm is definitely the recommended and most flexible way to deploy Falco, especially for production or highly customized setups.

The addon is intended for a different audience: Minikube users who want a simple, discoverable, one-command way to try Falco locally, similar to other built-in addons like ingress or metrics-server, even though those can also beinstalled via Helm.

This PR intentionally avoids reintroducing Falco into the ISO or kernel module path, and does not replace the Helm-based workflow. Helm remains the preferred approach for advanced use cases, while the addon targets quick experimentation,
learning, and demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add falco back to the new iso

5 participants