wip: Remove depdendency on crictl for listing containers #22352

medyagh · 2025-12-28T05:51:21Z

Remove depdendency on crictl for listing containers
also Dynamically Detecting runtime_root for crio because CRIO on VM and KIC different in config crio on in KIC uses different runtime-root than ISO ("open /run/runc: no such file or directory") #22326

The crictl dependency for listing containers has been removed in favor of direct OCI runtime calls, which provides a more reliable "ground truth" of running containers. as discussed here
#22264

…ith annotation-based filtering and dynamic CRIO runtime detection.

…t functions, dynamically for crio and defaulting to runc for containerd/docker.

…lly determining for CRIO and explicitly setting for Docker.

…perations by parsing `crio config`.

k8s-ci-robot · 2025-12-28T05:51:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2025-12-28T06:04:14Z

/ok-to-test

medyagh · 2025-12-28T06:31:36Z

pkg/minikube/cruntime/crio.go

+}
+
+// crioOCIInfo returns the runtime executable (e.g. runc) and its root path by parsing 'crio config'
+func crioOCIInfo(cr CommandRunner) (string, string, error) {


once we unify the KIC/VM crio configs this step should only be done on None Driver for crio.

minikube-pr-bot · 2025-12-28T06:56:14Z

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22352 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 40.1s    │ 39.5s                  │
│ enable ingress │ 16.3s    │ 17.0s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube ingress: 17.4s 16.3s 16.3s 15.8s 15.8s
Times for minikube (PR 22352) ingress: 17.4s 16.9s 16.4s 16.9s 17.3s

Times for minikube start: 40.9s 40.8s 41.8s 38.3s 38.6s
Times for minikube (PR 22352) start: 40.8s 39.0s 38.4s 38.3s 40.9s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22352 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.1s    │ 21.3s                  │
│ enable ingress │ 11.1s    │ 10.7s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube ingress: 10.7s 10.7s 10.7s 12.7s 10.7s
Times for minikube (PR 22352) ingress: 10.7s 10.7s 10.7s 10.7s 10.7s

Times for minikube start: 19.5s 21.7s 18.8s 19.2s 21.2s
Times for minikube (PR 22352) start: 18.3s 22.1s 21.9s 22.2s 21.9s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22352 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 18.8s    │ 19.0s                  │
│ enable ingress │ 23.2s    │ 23.2s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 16.7s 20.3s 16.8s 20.5s 19.9s
Times for minikube (PR 22352) start: 19.8s 19.7s 19.5s 19.6s 16.5s

Times for minikube ingress: 23.2s 23.2s 23.2s 23.2s 23.2s
Times for minikube (PR 22352) ingress: 23.2s 23.2s 23.2s 23.2s 23.2s

k8s-ci-robot · 2025-12-28T07:40:18Z

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-vfkit-docker-macos-arm	`9a79851`	link	false	`/test integration-vfkit-docker-macos-arm`
integration-docker-containerd-linux-x86	`9a79851`	link	true	`/test integration-docker-containerd-linux-x86`
integration-docker-containerd-linux-arm	`9a79851`	link	false	`/test integration-docker-containerd-linux-arm`
integration-docker-crio-linux-x86	`9a79851`	link	false	`/test integration-docker-crio-linux-x86`
integration-kvm-containerd-linux-x86	`9a79851`	link	true	`/test integration-kvm-containerd-linux-x86`
integration-kvm-docker-linux-x86	`9a79851`	link	true	`/test integration-kvm-docker-linux-x86`
integration-none-containerd-linux-x86	`9a79851`	link	unknown	`/test integration-none-containerd-linux-x86`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

minikube-pr-bot · 2025-12-28T08:22:06Z

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Windows (3 failed)	TestForceSystemdFlag(gopogh)	Unknown
Docker_Windows (3 failed)	TestForceSystemdEnv(gopogh)	Unknown
Docker_Windows (3 failed)	TestErrorSpam/setup(gopogh)	Unknown
KVM_Linux_containerd (6 failed)	TestPause/serial/VerifyStatus(gopogh)	0.00% (chart)
KVM_Linux_containerd (6 failed)	TestStartStop/group/old-k8s-version/serial/Pause(gopogh)	0.00% (chart)
KVM_Linux_containerd (6 failed)	TestStartStop/group/embed-certs/serial/Pause(gopogh)	0.00% (chart)
KVM_Linux_containerd (6 failed)	TestStartStop/group/no-preload/serial/Pause(gopogh)	0.00% (chart)
KVM_Linux_containerd (6 failed)	TestStartStop/group/default-k8s-diff-port/serial/Pause(gopogh)	0.00% (chart)
KVM_Linux_containerd (6 failed)	TestStartStop/group/newest-cni/serial/Pause(gopogh)	0.00% (chart)
KVM_Linux (3 failed)	TestFunctional/serial/SoftStart(gopogh)	0.00% (chart)
KVM_Linux (3 failed)	TestFunctional/serial/ExtraConfig(gopogh)	0.00% (chart)
KVM_Linux (3 failed)	TestFunctional/serial/ComponentHealth(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestForceSystemdFlag(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestForceSystemdEnv(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestPause/serial/VerifyStatus(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestStartStop/group/old-k8s-version/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestStartStop/group/no-preload/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestStartStop/group/embed-certs/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestStartStop/group/default-k8s-diff-port/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd_arm64 (8 failed)	TestStartStop/group/newest-cni/serial/Pause(gopogh)	1.96% (chart)
Docker_Linux_docker_arm64 (2 failed)	TestForceSystemdFlag(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (2 failed)	TestForceSystemdEnv(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestPause/serial/VerifyStatus(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestStartStop/group/no-preload/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestStartStop/group/old-k8s-version/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestStartStop/group/embed-certs/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestStartStop/group/newest-cni/serial/Pause(gopogh)	0.00% (chart)
Docker_Linux_containerd (6 failed)	TestStartStop/group/default-k8s-diff-port/serial/Pause(gopogh)	6.12% (chart)

Besides the following environments also have failed tests:

Docker_Linux_crio: 26 failed (gopogh)
Docker_Linux_crio_arm64: 27 failed (gopogh)

To see the flake rates of all tests by environment, click here.

medyagh added 6 commits December 27, 2025 21:34

feat: Refactor CRI container operations to use OCI runtime directly w…

a41777b

…ith annotation-based filtering and dynamic CRIO runtime detection.

feat: Pass OCI runtime and root parameters to CRI container managemen…

e48f5c3

…t functions, dynamically for crio and defaulting to runc for containerd/docker.

feat: pass OCI runtime and root to CRI container operations, dynamica…

0e833d4

…lly determining for CRIO and explicitly setting for Docker.

Dynamically determine CRI-O OCI runtime and root path for container o…

132fe6a

…perations by parsing `crio config`.

style: Reformat blank line

849e8c6

test: implement fake runc list -f json command for testing

1e1e0a2

k8s-ci-robot requested a review from nirs December 28, 2025 05:51

k8s-ci-robot requested a review from prezha December 28, 2025 05:51

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2025

refactor: replace hardcoded "runc" string with runcBinaryName constant

9a79851

medyagh changed the title ~~Remove depdendency on crictl for listing containers and dynamically detect crio runtime_root~~ Remove depdendency on crictl for listing containers Dec 28, 2025

medyagh changed the title ~~Remove depdendency on crictl for listing containers~~ wip: Remove depdendency on crictl for listing containers Dec 28, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 28, 2025

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 28, 2025

medyagh commented Dec 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

wip: Remove depdendency on crictl for listing containers #22352

wip: Remove depdendency on crictl for listing containers #22352

medyagh commented Dec 28, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Dec 28, 2025

Uh oh!

medyagh commented Dec 28, 2025

Uh oh!

medyagh Dec 28, 2025

Uh oh!

minikube-pr-bot commented Dec 28, 2025

Uh oh!

k8s-ci-robot commented Dec 28, 2025

Uh oh!

minikube-pr-bot commented Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wip: Remove depdendency on crictl for listing containers #22352

Are you sure you want to change the base?

wip: Remove depdendency on crictl for listing containers #22352

Conversation

medyagh commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Dec 28, 2025

Uh oh!

medyagh commented Dec 28, 2025

Uh oh!

medyagh Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

minikube-pr-bot commented Dec 28, 2025

Uh oh!

k8s-ci-robot commented Dec 28, 2025

Uh oh!

minikube-pr-bot commented Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

medyagh commented Dec 28, 2025 •

edited

Loading