Add --version/-v flag to schedule-builder#3548
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 4, 2024
Merged
Add --version/-v flag to schedule-builder#3548k8s-ci-robot merged 1 commit intokubernetes:masterfrom
--version/-v flag to schedule-builder#3548k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
This allows to print the version and exit. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
cpanato
approved these changes
Apr 4, 2024
Member
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
why not have it own command? as we have similar for other tools?
but it is a non blocking
/lgtm
/hold
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
We have no subcommands for the schedule builder at all. Should we introduce that? I'm not sure. |
Member
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows to print the version and exit.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?