Fix path for kubelet.env file in kubelet deb package#3625
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom May 28, 2024
Merged
Fix path for kubelet.env file in kubelet deb package#3625k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
xmudrii
changed the title
Member
Author
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
Member
Author
$ dpkg -L kubelet | grep /kubelet
/etc/default/kubelet
/lib/systemd/system/kubelet.service
/usr/bin/kubelet
/usr/share/doc/kubelet
/usr/share/doc/kubelet/LICENSE
/usr/share/doc/kubelet/README.md
/var/lib/kubelet
/var/lib/kubelet/.kubelet-keep |
This was referenced May 28, 2024
saschagrunert
approved these changes
May 28, 2024
Member
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
Code LGTM, but the release note has a typo deafult
k8s-ci-robot
added
the
lgtm
Member
Author
|
@saschagrunert Good point, fixed! 😅 |
cpanato
approved these changes
May 28, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We received two reports that our
kubeletDebian package installskubelet.envfile in a wrong location:I was able to confirm these reports. As per some guidelines:
/etc/defaultshould be used on Debian-based operating systems/etc/sysconfigshould be used on RPM-based operating systemsWe partially fixed the issue a while ago with #3279, by ensuring that
kubeadmis going to read the file from the correct path, but we didn't ensure that we install the file in the correct location. This is now fixed with this PR.I tried building and installing the package locally to make sure the file is created in the correct location. This change will be applied to all
kubeletpackages that we build (for all minor releases) once this PR is merged. I don't expect this to regress in any way. 🤞Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato @puerco
cc @kubernetes/release-engineering