-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version discovery for cri-tools and kubernetes-cni packages #3629
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
Signed-off-by: Marko Mudrinić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/skip |
/override "Dependency Review / dependency-review (pull_request)" |
@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "dependency-review" |
@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add version discovery to the
krel obs specs
command forcri-tools
andkubernetes-cni
packages. If the version is not provided, the latest version will be fetched from GitHub and used to create the package sources and specs. Prior to this change, if the version wasn't provided, the command would fail. This change is making it easier to implement tests.Which issue(s) this PR fixes:
Required for #3589
Special notes for your reviewer:
This PR requires kubernetes-sigs/release-utils#104. I bumped the dependency to the latest revision, but we might want to do a new release-utils release as well.
Does this PR introduce a user-facing change?
/assign @cpanato @saschagrunert @puerco
cc @kubernetes/release-engineering