Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually Remove Kubernetes 1.24 jobs #30563

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Manually Remove Kubernetes 1.24 jobs #30563

merged 2 commits into from
Aug 31, 2023

Conversation

jeremyrickard
Copy link
Contributor

This PR is intended to drop the 1.24 jobs by replicating the work done to remove the 1.23 jobs in #29387.

Notably:

  • This continues the pattern of commenting out k8s-beta in releng/test_config.yaml.
  • k8s beta dashboard content is commented out with TODO comments for 1.29
  • Removes 1.24 jobs sig-windows

Note: there were some TODO commented out things left over from the previous attempt this that should have been undone when we created the 1.28 branch and jobs. We should double check everything when it is time to do the 1.29 jobs.

/assign @xmudrii @jimangel @marosset
cc https://github.com/orgs/kubernetes/teams/release-engineering

/hold for discussion if this approach is still valid

There are some follow up issues from the previous drop of 1.23 jobs that we should also follow up on:

#29388
#29390
kubernetes/sig-release#2227

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Aug 30, 2023
@jeremyrickard jeremyrickard changed the title Manually Remove Kubernetes 1.24 jobs WIP: Manually Remove Kubernetes 1.24 jobs Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2023
@jeremyrickard
Manually remove 1.24 jobs
5a00879 
Signed-off-by: Jeremy Rickard <[email protected]>
@jeremyrickard jeremyrickard changed the title WIP: Manually Remove Kubernetes 1.24 jobs Manually Remove Kubernetes 1.24 jobs Aug 30, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2023
xmudrii
xmudrii suggested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some issue with periodic annotations that we should sort out before merging this PR. Let's sync about that and see how should we handle that.

config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml Outdated
@@ -326,7 +326,7 @@ periodics:
- 'perfDashJobType: performance'
- 'perfDashBuildsCount: 500'
- annotations:
fork-per-release-periodic-interval: 24h
fork-per-release-periodic-interval: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, there must be one interval left here or we're going to run into issues the next time we rotate jobs.

config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml Outdated
@@ -393,7 +393,7 @@ periodics:
cpu: "4"
memory: 36Gi
- annotations:
fork-per-release-periodic-interval: 24h
fork-per-release-periodic-interval: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml Outdated
@@ -437,7 +437,7 @@ periodics:
securityContext:
privileged: true
- annotations:
fork-per-release-periodic-interval: 24h
fork-per-release-periodic-interval: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml Outdated
@@ -482,7 +482,7 @@ periodics:
securityContext:
privileged: true
- annotations:
fork-per-release-periodic-interval: 24h
fork-per-release-periodic-interval: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

xmudrii
xmudrii approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
marosset
marosset approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows changes LGTM

@jeremyrickard
Copy link
Contributor Author

/assign wojtek-t

@jeremyrickard
Copy link
Contributor Author

/assign michelle192837

@ameukam
Copy link
Member

ameukam commented Aug 31, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, jeremyrickard, marosset, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@jeremyrickard
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
xmcqueen
xmcqueen reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@xmcqueen xmcqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f6a67b0 into kubernetes:master Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

@jeremyrickard: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.24-windows-presubmits.yaml using file ``
  • key release-1.24-windows.yaml using file ``
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key 1.24.yaml using file ``
  • key 1.25.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
  • key 1.27.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
  • key 1.28.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.28.yaml

In response to this:

This PR is intended to drop the 1.24 jobs by replicating the work done to remove the 1.23 jobs in #29387.

Notably:

  • This continues the pattern of commenting out k8s-beta in releng/test_config.yaml.
  • k8s beta dashboard content is commented out with TODO comments for 1.29
  • Removes 1.24 jobs sig-windows

Note: there were some TODO commented out things left over from the previous attempt this that should have been undone when we created the 1.28 branch and jobs. We should double check everything when it is time to do the 1.29 jobs.

/assign @xmudrii @jimangel @marosset
cc https://github.com/orgs/kubernetes/teams/release-engineering

/hold for discussion if this approach is still valid

There are some follow up issues from the previous drop of 1.23 jobs that we should also follow up on:

#29388
#29390
kubernetes/sig-release#2227

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmcqueen xmcqueen xmcqueen left review comments

@xmudrii xmudrii xmudrii approved these changes

@marosset marosset marosset approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@michelle192837 michelle192837

@jimangel jimangel

@wojtek-t wojtek-t

@marosset marosset

@xmudrii xmudrii

@xmcqueen xmcqueen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeremyrickard @ameukam @k8s-ci-robot @marosset @xmudrii @xmcqueen @michelle192837 @jimangel @wojtek-t