Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing 1.25 jobs #31139

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Removing 1.25 jobs #31139

merged 1 commit into from
Nov 17, 2023

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Oct 26, 2023 •
edited
Loading

/hold for review from sig-release folks and also 1.25 EOL

Here are the steps I followed for these changes

  • Manually removed all references to stable4 / release-1.25 in `releng/test_config.ymlt
  • Ran python3 releng/generate_tests.py --yaml-config-path=./releng/test_config.yaml
  • Manually deleted release-1.25-windows.yaml, release-1.25-windows-presubmits.yml, 1.25.yaml
  • Manually removed 1.25 entries from sig-release/config.yaml and sig-windows/config.yaml

My understanding is that currently release jobs must be cleaned up manually based on comments in #29387

In both of the previous examples the next release branch was already created but in this case the 1.29 release branch has not yet been created.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Oct 26, 2023
@marosset
Copy link
Contributor Author

/assign @xmudrii @jeremyrickard

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@marosset
Copy link
Contributor Author

I'll rebase soon

xmudrii
xmudrii suggested changes Nov 16, 2023
View reviewed changes
config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml Outdated
@@ -176,47 +176,3 @@ periodics:
requests:
memory: "9000Mi"
cpu: 2000m

- name: ci-kubernetes-e2e-kubeadm-kinder-1-25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check with the SIG CL folks if this requires any change in https://github.com/kubernetes/kubeadm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmudrii - do you know who we can reach out to for this?
This job was in the sig-release-1.25-informing testgrid dashboard which I'm removing in this PR.
Should I just remove it from the dashboard for now instead of removing the entire job?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 Can you help with this? ^^

Copy link
Member

@neolit123 neolit123 Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's OK to either remove these jobs from the dashboards or remove them entirely (since 1.25 is out of support).
the diff SGTM the way it is, right now thanks.

kubeadm maintainers will push a change when the 1.29 branch and dashboards exist (21st of Nov), and that change will also include removal of the 1.25 jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarification @neolit123!

releng/test_config.yaml Outdated Show resolved Hide resolved
releng/test_config.yaml Show resolved Hide resolved
releng/test_config.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2023
@marosset
Copy link
Contributor Author

@xmudrii - I think this is ready for another review

xmudrii
xmudrii approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marosset!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 16, 2023
@marosset
Copy link
Contributor Author

@neolit123 if things look good now can you approve for config/jobs/kubernetes/sig-cluster-lifecycle/OWNERS ?

neolit123
neolit123 reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 17, 2023
@dims
Copy link
Member

dims commented Nov 17, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2023
@marosset
Copy link
Contributor Author

/approve /lgtm

Thanks @dims!
I was just about to ping you on this :P

@xmudrii
Copy link
Member

xmudrii commented Nov 17, 2023

This looks like a real failure, but let's try retesting just in case
/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, marosset, neolit123, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor Author

/test pull-test-infra-unit-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@marosset
Removing 1.25 jobs
7714bb3 
Signed-off-by: Mark Rossetti <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@marosset
Copy link
Contributor Author

/test pull-test-infra-integration

@marosset
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2023
@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit ef6b271 into kubernetes:master Nov 17, 2023
8 checks passed
@k8s-ci-robot
Copy link
Contributor

@marosset: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.25-windows-presubmits.yaml using file ``
  • key release-1.25-windows.yaml using file ``
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key kubeadm-kinder.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml
  • key 1.25.yaml using file ``

In response to this:

/hold for review from sig-release folks and also 1.25 EOL

Here are the steps I followed for these changes

  • Manually removed all references to stable4 / release-1.25 in `releng/test_config.ymlt
  • Ran python3 releng/generate_tests.py --yaml-config-path=./releng/test_config.yaml
  • Manually deleted release-1.25-windows.yaml, release-1.25-windows-presubmits.yml, 1.25.yaml
  • Manually removed 1.25 entries from sig-release/config.yaml and sig-windows/config.yaml

My understanding is that currently release jobs must be cleaned up manually based on comments in #29387

In both of the previous examples the next release branch was already created but in this case the 1.29 release branch has not yet been created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@neolit123 neolit123 neolit123 left review comments

@cici37 cici37 Awaiting requested review from cici37

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

Assignees

@dims dims

@xmudrii xmudrii

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marosset @dims @xmudrii @k8s-ci-robot @jeremyrickard @neolit123