-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Remove discovery-store from pull-kops-aws-distro-al2023 #35250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e654dbf to
89dfffe
Compare
89dfffe to
b28ddaa
Compare
Signed-off-by: Marko Mudrinić <[email protected]>
b28ddaa to
ace26b0
Compare
| if extra_flags is None: | ||
| extra_flags = [] | ||
|
|
||
| if irsa and cloud == "aws" and scenario is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this hack so lint passes, it'll be reverted after testing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, rifelpet, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@xmudrii: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follows up on kubernetes/kops#17520
This PR removes the
--discovery-storeflag from thepull-kops-aws-distro-al2023job in order to test if dynamic bucket creation works properly. This job is an optional job that's triggered manually. If it works for this job, we'll update all other jobs later on./assign @ameukam