Skip to content

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 31, 2025

Follows up on kubernetes/kops#17520

This PR removes the --discovery-store flag from the pull-kops-aws-distro-al2023 job in order to test if dynamic bucket creation works properly. This job is an optional job that's triggered manually. If it works for this job, we'll update all other jobs later on.

/assign @ameukam

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 31, 2025
@ameukam
Copy link
Member

ameukam commented Jul 31, 2025

/lgtm
/approve
cc @hakman @rifelpet

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2025
@xmudrii xmudrii force-pushed the test-disco-store branch from e654dbf to 89dfffe Compare July 31, 2025 16:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@xmudrii xmudrii force-pushed the test-disco-store branch from 89dfffe to b28ddaa Compare July 31, 2025 16:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2025
if extra_flags is None:
extra_flags = []

if irsa and cloud == "aws" and scenario is None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add this hack so lint passes, it'll be reverted after testing.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 1, 2025

@ameukam @rifelpet @hakman Can you please PTAL again, the linter is now fixed?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, rifelpet, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d803f6a into kubernetes:master Aug 1, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@xmudrii: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-presubmits-distros.yaml using file config/jobs/kubernetes/kops/kops-presubmits-distros.yaml

In response to this:

Follows up on kubernetes/kops#17520

This PR removes the --discovery-store flag from the pull-kops-aws-distro-al2023 job in order to test if dynamic bucket creation works properly. This job is an optional job that's triggered manually. If it works for this job, we'll update all other jobs later on.

/assign @ameukam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii xmudrii deleted the test-disco-store branch August 1, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants