Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc string on how to update {eol,schedule}.yaml #45982

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add doc string on how to update {eol,schedule}.yaml #45982

merged 1 commit into from
Apr 23, 2024

Conversation

saschagrunert
Copy link
Member

The merge of kubernetes/release#3583 introduced a documentation string to both files mentioning how to update them. We now sync the changes to match the output of the latest schedule-builder tool revision.

/cc @kubernetes/release-engineering

@saschagrunert
Add doc string on how to update {eol,schedule}.yaml
e6c9d69 
The merge of kubernetes/release#3583 introduced
a documentation string to both files mentioning how to update them. We
now sync the changes to match the output of the latest schedule-builder
tool revision.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-engineering.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The merge of kubernetes/release#3583 introduced a documentation string to both files mentioning how to update them. We now sync the changes to match the output of the latest schedule-builder tool revision.

/cc @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
cpanato
cpanato approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f31b29c40c38e70ea6604f5f91f00b8a13dd51fd

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e6c9d69
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66277f4c6a53f500084ef899
😎 Deploy Preview https://deploy-preview-45982--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot merged commit 5752866 into kubernetes:main Apr 23, 2024
6 checks passed
@saschagrunert saschagrunert deleted the schedule-builder-docs branch April 23, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @cpanato