Correct misleading way to determine whether Pods are terminating #53407
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To find out if a Pod is terminating, you check .metadata.deletionGracePeriodSeconds Deleted Pods don't count; once the grace period has expired, either the grace period is zero or the Pod no longer exists (and therefore do not contribute to resource quota).
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find out if a Pod is terminating, you check
.metadata.deletionGracePeriodSeconds. Update the ResourceQuota docs to make that clear.Deleted Pods don't count; once the grace period has expired, either the grace period is zero or the Pod no longer exists (and therefore do not contribute to resource quota).
/language en
Submitting this as a draft.
I think the existing documentation correctly documents how Kubernetes behaves, but I also think that that behavior is wrong. See kubernetes/kubernetes#135411