Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech: simplify and improve the LogOutput auto-scroll #810

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 3, 2023

Changes

  • simplify and improve the LogOutput auto-scroll
    • make the whole auto-scroll logic inside of LogOutput
    • avoid stateful decision - base on actual render

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 11:03am

@rangoo94 rangoo94 merged commit 434ff83 into develop Aug 3, 2023
7 checks passed
@rangoo94 rangoo94 deleted the dawid/tech/fix-and-simplify-log-auto-scroll branch August 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants