Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve summary grid / always show filtering by timeframe #812

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix: improve summary grid / always show filtering by timeframe #812

merged 2 commits into from
Aug 3, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 3, 2023

Changes

  • Improve Summary Grid
    • Better performance
    • Better UX, because of avoiding page jump (conditional render)
  • Always show timeframe filter
    • Otherwise, when the test / test suite has only executions older than 7 days we don't display at all

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview Aug 3, 2023 11:40am

Toxer10
Toxer10 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Toxer10 Toxer10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@rangoo94 rangoo94 merged commit 2df289e into develop Aug 3, 2023
7 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/improve-summary-grid branch August 3, 2023 14:52
@rangoo94 rangoo94 mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toxer10 Toxer10 Toxer10 approved these changes

@haneabogdan haneabogdan haneabogdan approved these changes

@exu exu Awaiting requested review from exu exu is a code owner

@pavloburchak pavloburchak Awaiting requested review from pavloburchak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard logs for tests executed outside of timeframe: 7 days
3 participants
@rangoo94 @haneabogdan @Toxer10