Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AI insights tab #813

Merged
merged 11 commits into from
Aug 3, 2023
Merged

feat: AI insights tab #813

merged 11 commits into from
Aug 3, 2023

Conversation

haneabogdan
Copy link
Contributor

This PR...

Changes

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 1:47pm

Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with padding, but it looks good when the screen height is smaller

Zrzut ekranu 2023-08-3 o 15 06 34

src/plugins/definitions/ai-insights.tsx Outdated Show resolved Hide resolved
src/components/molecules/AiInsightsTab/AiInsightsTab.tsx Outdated Show resolved Hide resolved
src/utils/externalLinks.ts Show resolved Hide resolved
@haneabogdan
Copy link
Contributor Author

@rangoo94 can you detail what is the problem with the padding?

@rangoo94
Copy link
Member

rangoo94 commented Aug 3, 2023

@rangoo94 can you detail what is the problem with the padding?

The padding on the top and bottom are different. That's because of min-height: 25vh - I think that it should be only in case there is an actual log displayed, not for consent / redirect message.

@haneabogdan
Copy link
Contributor Author

min-height: 25vh

weirdly enough, I can't see any differences with/without it. will merge the PR for now and analyse this further

@rangoo94
Copy link
Member

rangoo94 commented Aug 3, 2023

weirdly enough, I can't see any differences with/without it. will merge the PR for now and analyze this further

Maybe you have small window or DevTools opened?

It starts being incorrect on screen height > 952px, and each 4px of screen height makes the padding 1px too big (25vh). In example, when your window has 1120px, the bottom padding is 42px too big (because of the element's height).

Zrzut ekranu 2023-08-3 o 15 36 36

@haneabogdan haneabogdan merged commit 3eb4b36 into develop Aug 3, 2023
6 of 7 checks passed
@haneabogdan haneabogdan deleted the bogdan/feat/ai-insight branch August 3, 2023 13:52
@rangoo94 rangoo94 mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants