feat: add Edit Test link to dropdown #826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haneabogdan
requested review from
exu,
Toxer10 and
pavloburchak
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rangoo94
reviewed
Aug 10, 2023
Comment on lines
+127
to
+129
| const onEditTest = () => { | ||
| onSettingsTabChange('test'); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const onEditTest = () => { | |
| onSettingsTabChange('test'); | |
| }; | |
| const onEditTest = useLastCallback(() => { | |
| onSettingsTabChange('test'); | |
| }); |
or
Suggested change
| const onEditTest = () => { | |
| onSettingsTabChange('test'); | |
| }; | |
| const onEditTest = useCallback(() => { | |
| onSettingsTabChange('test'); | |
| }, [onSettingsTabChange]); |
| @@ -154,7 +158,10 @@ const EntityDetailsContent: React.FC<EntityDetailsContentProps> = ({ | |||
| />, | |||
| <DotsDropdown | |||
| key="entity-options" | |||
| items={[{key: 1, label: <span onClick={onAbortAllExecutionsClick}>Abort all executions</span>}]} | |||
| items={[ | |||
| {key: 1, label: <span onClick={onEditTest}>Edit Test</span>}, | |||
There was a problem hiding this comment.
Is it meant to be displayed for both Tests and Test Suites?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
How to test it
screenshots
Checklist