fix: load image metadata when needed / load platform-specific manifes…

…t with Crane fetcher (#6018)

* fix: fetch image metadata when actually needed
* fix: try to obtain image specific for current platform in Crane fetcher

pkg/imageinspector/cranefetcher.go

@@ -6,12 +6,14 @@ import (
 	"encoding/json"
 	"fmt"
 	"regexp"
+	"runtime"
 	"strconv"
 	"strings"
 	"time"
 
 	"github.com/google/go-containerregistry/pkg/authn"
 	"github.com/google/go-containerregistry/pkg/crane"
+	v1 "github.com/google/go-containerregistry/pkg/v1"
 	corev1 "k8s.io/api/core/v1"
 
 	"github.com/kubeshop/testkube/pkg/utils"
@@ -42,14 +44,21 @@ func (c *craneFetcher) Fetch(ctx context.Context, registry, image string, pullSe
 	}
 
 	// Select the auth
+	cranePlatformOption := crane.WithPlatform(&v1.Platform{OS: runtime.GOOS, Architecture: runtime.GOARCH})
 	craneOptions := []crane.Option{crane.WithContext(ctx)}
 	if len(authConfigs) > 0 {
 		craneOptions = append(craneOptions, crane.WithAuth(authn.FromConfig(authConfigs[0])))
 	}
 
 	// Fetch the image configuration
 	fetchedAt := time.Now()
-	serializedImageConfig, err := crane.Config(image, craneOptions...)
+	serializedImageConfig, err := crane.Config(image, append(craneOptions, cranePlatformOption)...)
+
+	// Retry again without specifying platform
+	if err != nil && (strings.Contains(err.Error(), "no child") || strings.Contains(err.Error(), "not known")) {
+		serializedImageConfig, err = crane.Config(image, craneOptions...)
+	}
+
 	if err != nil {
 		return nil, err
 	}

pkg/testworkflows/testworkflowprocessor/processor.go

@@ -212,7 +212,7 @@ func (p *processor) Bundle(ctx context.Context, workflow *testworkflowsv1.TestWo
 
 	// Load the image details when necessary
 	hasPodSecurityContextGroup := podConfig.SecurityContext != nil && podConfig.SecurityContext.RunAsGroup != nil
-	imageNames := root.GetImages(hasPodSecurityContextGroup)
+	imageNames := root.GetImages(!hasPodSecurityContextGroup)
 	images := make(map[string]*imageinspector.Info)
 	imageNameResolutions := map[string]string{}
 	for image, needsMetadata := range imageNames {