Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add devbox command #5971

Merged
merged 28 commits into from
Oct 31, 2024
Merged

feat: add devbox command #5971

merged 28 commits into from
Oct 31, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 25, 2024 •
edited
Loading

Pull request description

Add a command to run Testkube Agent for development with fast live changes on a remote cluster.

go run cmd/kubectl-testkube/main.go dev --name dawid --sync test/playwright --open
Zrzut ekranu 2024-10-28 o 12 09 54

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Base automatically changed from dawid/feat/extract-control-plane to main October 25, 2024 13:57
@rangoo94 rangoo94 force-pushed the dawid/feat/add-devbox-command branch from 294d564 to a535434 Compare October 25, 2024 13:58
@rangoo94 rangoo94 marked this pull request as ready for review October 28, 2024 11:23
@rangoo94 rangoo94 requested review from a team as code owners October 28, 2024 11:23
vsukhin
vsukhin reviewed Oct 30, 2024
View reviewed changes
cmd/tcl/kubectl-testkube/devbox/devutils/objectstorage.go Outdated
Containers: []corev1.Container{
{
Name: "minio",
Image: "minio/minio:RELEASE.2024-10-13T13-34-11Z",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a lot of diffferent hardcodings, const values in the code like this. might be it's ok for dev tool, but definitely not for prod code

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2024
View reviewed changes
cmd/tcl/devbox-binary-storage/main.go Dismissed Show dismissed Hide dismissed
cmd/tcl/devbox-binary-storage/main.go Dismissed Show dismissed Hide dismissed
cmd/tcl/devbox-binary-storage/main.go Dismissed Show dismissed Hide dismissed
cmd/tcl/devbox-binary-storage/main.go Dismissed Show dismissed Hide dismissed
cmd/tcl/devbox-binary-storage/main.go Dismissed Show dismissed Hide dismissed
cmd/tcl/kubectl-testkube/devbox/devutils/binarystorage.go Dismissed Show dismissed Hide dismissed
@rangoo94 rangoo94 merged commit 23a55eb into main Oct 31, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/add-devbox-command branch October 31, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WitoDelnat WitoDelnat WitoDelnat approved these changes

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rangoo94 @vsukhin @WitoDelnat