fix(cli): adding validation when trying to run resource that does not exist #3895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@danielbdias I think this would be a good candidate for creating a small video recording the new CLI behavior, what do you think? |
xoscar
reviewed
Jun 4, 2024
| @@ -102,3 +121,20 @@ func validRequiredGatesMsg() string { | |||
|
|
|||
| return "valid options: " + strings.Join(opts, ", ") | |||
| } | |||
|
|
|||
| func hasValidResourceFiles() bool { | |||
| if len(runParams.DefinitionFiles) == 0 { | |||
There was a problem hiding this comment.
Should an empty list be valid?
There was a problem hiding this comment.
Yes, in the case of the OSS test. (We can use --id for that case.)
Perhaps we should have something to validate when using run groups, too?
danielbdias
force-pushed
the
fix/cli-file-not-found-behavior
branch
from
4452882 to
9549df5
Compare
@xoscar instead of adding a video, I added a small image showing the behavior, does it make sense? |
xoscar
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validation on the CLI to inform the user that they tried to run a test / testsuite that doesn't exist.
Example:
Changes
runcommand to check if definition files existsChecklist