-
Notifications
You must be signed in to change notification settings - Fork 79
fix(cli): adding validation when trying to run resource that does not exist #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@danielbdias I think this would be a good candidate for creating a small video recording the new CLI behavior, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @danielbdias I left a small comment
@@ -102,3 +121,20 @@ func validRequiredGatesMsg() string { | |||
|
|||
return "valid options: " + strings.Join(opts, ", ") | |||
} | |||
|
|||
func hasValidResourceFiles() bool { | |||
if len(runParams.DefinitionFiles) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an empty list be valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in the case of the OSS test. (We can use --id for that case.)
Perhaps we should have something to validate when using run groups, too?
4452882
to
9549df5
Compare
@xoscar instead of adding a video, I added a small image showing the behavior, does it make sense? |
This PR adds a validation on the CLI to inform the user that they tried to run a test / testsuite that doesn't exist.
Example:

Changes
run
command to check if definition files existsChecklist