-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Prepare for the removal of artifacts directories next #79
Prepare for the removal of artifacts directories next #79
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following users are mentioned in OWNERS file(s) but are not members of the kubesphere org. Once all users have been added as members of the org, you can trigger verification by writing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. And please fix the conflicts.
Dockerfile-on-prem
Outdated
|
||
COPY target/*.jar /home | ||
|
||
ENTRYPOINT java -jar *.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using wildcards here?
Dockerfile-on-prem
Outdated
@@ -0,0 +1,9 @@ | |||
FROM harbor.devops.kubesphere.local:30280/library/java:openjdk-8-jre-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend that providing some description about the purpose of this file here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the base image harbor.devops.kubesphere.local:30280/library/java:openjdk-8-jre-alpine
comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make a tutorial about devops hand's lab in offline mode.
Dockerfile-online
Outdated
|
||
COPY target/*.jar /home | ||
|
||
ENTRYPOINT java -jar *.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using wildcards here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause we couldn't know the specific jar name directly. If you have any better suggestions, you can come up with them.
Thanks for your review. I'll fix them as soon as possible. |
Signed-off-by: johnniang <[email protected]>
Signed-off-by: johnniang <[email protected]>
Signed-off-by: johnniang <[email protected]>
Signed-off-by: johnniang <[email protected]>
bda26a9
to
0b78870
Compare
Signed-off-by: johnniang <[email protected]>
There're too many people who are creating PRs for test purposes. I'm going to close all PRs. And try to disable the PR feature. And we can maintain the sample project in another ways. |
I removed
artifacts/m2
folder according to this instruction: https://docs.github.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository.This PR is aimed to prepare for the removal of artifacts directories next.
What needs to be noted here is what needs to be done after the merge:
wget -c https://repo1.maven.org/maven2/com/madgag/bfg/1.14.0/bfg-1.14.0.jar -P ~/Downloads
git reflog expire --expire=now --all && git gc --prune=now --aggressive
Before:
The result:
Close #76
Close #74
/kind optimization