Trait pyroscope #363
Open
Trait pyroscope #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xueliang Yang <[email protected]>
nowmyself-togo-anywhere
requested review from
wangyikewxgm and
wonderflow
as code owners
Merged
3 tasks
nowmyself-togo-anywhere
force-pushed
the
trait-pyroscope
branch
from
27ee20c to
838a688
Compare
|
如果按照这样把pyroscoep做成一个trait意味着每个组件都会创建一套完整pyroscope server包括deployemnt、serveice、pv/pvc，我觉得这个成本是不可接受的。 |
Signed-off-by: Xueliang Yang <[email protected]>
nowmyself-togo-anywhere
force-pushed
the
trait-pyroscope
branch
from
838a688 to
411f383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
How has this code been tested?
Checklist
I have:
[Addon]or[Trait]).