Skip to content

Chore/upgrade go version #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PushparajShetty
Copy link
Contributor

@PushparajShetty PushparajShetty commented Jun 20, 2025

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Summary by cubic

Upgraded the Go version in go.mod from 1.22.0 to 1.23.8 to use the latest language features and improvements.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 1 issue across 1 file. Review it in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@PushparajShetty PushparajShetty force-pushed the chore/upgrade-go-version branch 2 times, most recently from 022f83e to 2bd40a7 Compare June 20, 2025 05:15
@PushparajShetty PushparajShetty force-pushed the chore/upgrade-go-version branch from 86dd2f1 to 42bc9c8 Compare June 20, 2025 09:06
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign the DCO?

@PushparajShetty
Copy link
Contributor Author

Can you sign the DCO?

Hi @FogDong
I’m encountering some issues upgrading the Go version—right now, go mod tidy fails even on the master branch. It looks like more extensive changes are needed.
I’ll close this PR for now and reopen once everything is working properly.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants