-
Notifications
You must be signed in to change notification settings - Fork 52
CNV-71593:Tree view, CPU, memory, network columns sampling seem incon… #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
Conversation
|
@aviavissar: This pull request references CNV-71593 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aviavissar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| const NetworkPercentage: FC<NetworkPercentageProps> = ({ vm, vmi }) => { | ||
| const { currentTime, duration } = useDuration(); | ||
| const queries = useMemo(() => getUtilizationQueries({ duration, obj: vmi }), [vmi, duration]); | ||
| const [networkIn] = usePrometheusPoll({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this will hurt performance badly
CC: @upalatucci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes badly. This is why we have a query for the whole list and not for each row

##JIRA: https://issues.redhat.com/browse/CNV-71593?filter=-1
📝 Description
On Virtualization view, VMs tree view, when selecting CPU, Memory or network columns, the values presentation is inconsistent
🎥 Demo
Summary by CodeRabbit
New Features
Improvements
Documentation
Dependencies
✏️ Tip: You can customize this high-level summary in your review settings.