Skip to content

Conversation

@aviavissar
Copy link
Contributor

##JIRA: https://issues.redhat.com/browse/CNV-71593?filter=-1

📝 Description

On Virtualization view, VMs tree view, when selecting CPU, Memory or network columns, the values presentation is inconsistent

fix the incoonsistently

🎥 Demo

image

Summary by CodeRabbit

  • New Features

    • Added Storage Migrations workflow with MigPlan management and actions (create, delete, review).
    • Introduced network usage tracking for virtual machines.
    • Enhanced boot order device handling and sorting.
  • Improvements

    • Simplified CPU and memory metrics computation.
    • Refined VM list filtering and display with responsive sizing.
    • Updated translations for Storage Migrations and network configuration.
  • Documentation

    • Added telemetry configuration guide for local development.
  • Dependencies

    • Updated axios to latest compatible version.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 15, 2025

@aviavissar: This pull request references CNV-71593 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.z" version, but no target version was set.

Details

In response to this:

##JIRA: https://issues.redhat.com/browse/CNV-71593?filter=-1

📝 Description

On Virtualization view, VMs tree view, when selecting CPU, Memory or network columns, the values presentation is inconsistent

fix the incoonsistently

🎥 Demo

image

Summary by CodeRabbit

  • New Features

  • Added Storage Migrations workflow with MigPlan management and actions (create, delete, review).

  • Introduced network usage tracking for virtual machines.

  • Enhanced boot order device handling and sorting.

  • Improvements

  • Simplified CPU and memory metrics computation.

  • Refined VM list filtering and display with responsive sizing.

  • Updated translations for Storage Migrations and network configuration.

  • Documentation

  • Added telemetry configuration guide for local development.

  • Dependencies

  • Updated axios to latest compatible version.

✏️ Tip: You can customize this high-level summary in your review settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from lkladnit and rszwajko December 15, 2025 10:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aviavissar
Once this PR has been reviewed and has the lgtm label, please assign adamviktora for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

const NetworkPercentage: FC<NetworkPercentageProps> = ({ vm, vmi }) => {
const { currentTime, duration } = useDuration();
const queries = useMemo(() => getUtilizationQueries({ duration, obj: vmi }), [vmi, duration]);
const [networkIn] = usePrometheusPoll({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this will hurt performance badly
CC: @upalatucci

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes badly. This is why we have a query for the whole list and not for each row

@rszwajko rszwajko requested a review from upalatucci December 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants