Skip to content

Revert packages update #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Revert packages update #86

wants to merge 2 commits into from

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Mar 18, 2025

What this PR does / why we need it:
Reverts #80 #82
One of them is not by Renovate which is now the one we are based on.
The other is by Renovate but seems false positive according

callgraph -format=digraph   ./... | digraph nodes | egrep "golang.org/x/net/html.*Parse"
callgraph -format=digraph   ./... | digraph nodes | egrep "golang.org/x/net/html.*ParseFragment"
callgraph -format=digraph   ./... | digraph nodes | egrep "golang.org/x/net/html.*ParseFragmentWithOptions"
callgraph -format=digraph   ./... | digraph nodes | egrep "golang.org/x/net/html.*ParseWithOptions"

and we see there is some regression
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/2155/pull-e2e-cluster-network-addons-operator-br-marker-functests/1901952057175183360

Special notes for your reviewer:

Release note:

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2025
@kubevirt-bot kubevirt-bot requested review from qinqon and RamLavi March 18, 2025 12:21
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ramlavi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added size/XXL release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2025
@RamLavi
Copy link
Collaborator

RamLavi commented Mar 18, 2025

Hey @oshoval
regarding #80 why revert only because it's from dependabot? Other teams rely on both tools. if it's already merged, why work to revert?
regarding #81, how sure are we that this PR caused the regression in e2e? is it easy to reproduce? did we see it before?

@oshoval
Copy link
Collaborator Author

oshoval commented Mar 18, 2025

regarding 81, it is false positive (see PR desc please), and it failed today 3/3, trying to revert the bump which has those 2 PRs here
kubevirt/cluster-network-addons-operator#2156

about 80, this is not something that looks important (we can talk about it more offline if needed)
for now it blocks CNAO, and not part of the critical path
once CNAO is stable, we can bisect deeper, it isn't important atm, just because it is there
and we should stick to Renovate only, having 2 bots is noise

@oshoval
Copy link
Collaborator Author

oshoval commented Mar 18, 2025

kubevirt/cluster-network-addons-operator#2156 (comment)
seems it wont help
closing for now

@oshoval oshoval closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants