Update container image in PodSpec to use centos:10 #87

ashokpariya0 · 2025-03-26T08:45:09Z

Changed the container image from "centos" to "centos:10" in the PodSpec function to specify a more specific version of the CentOS image.

What this PR does / why we need it:
We encountered the following test failure while running the Bridge Marker E2E tests from CNAO:

Failure Summary:

[Fail] bridge-marker pod requiring bridge resource [It] should be started only when bridge is available on node 
/tmp/deploy.bridge-marker.oy9U/github.com/kubevirt/bridge-marker/tests/utils.go:157

Ran 2 of 2 Specs in 453.936 seconds
FAIL! -- 1 Passed | 1 Failed | 0 Pending | 0 Skipped

The pod created here(

bridge-marker/tests/marker_test.go

Line 88 in 5fb005a

    
           _, err := clientset.CoreV1().Pods(DefaultNamespace).Create(context.TODO(), podReq, v1.CreateOptions{})

) in this test (bridge-marker-test) encountered an ErrImagePull issue. The pod status was:

NAME                             READY   STATUS         RESTARTS   AGE
bridge-marker-test               0/1     ErrImagePull   0          118s

Upon examining the pod's describe output, we found the following error:

state:
      waiting:
        message: 'reading manifest latest in quay.io/centos: StatusCode: 404, "<!doctype html>\n<html lang=en>\n<title>404 Not Foun..."'
        reason: ErrImagePull

The issue is caused by the Kubernetes node attempting to pull the centos:latest image from the registry, which results in a 404 Not Found error.

Solution:
To resolve this issue, we will update the image to use a specific tag instead of the default centos image.

Special notes for your reviewer:

Release note:

None

Changed the container image from "centos" to "centos:10" in the PodSpec function to specify a more specific version of the CentOS image. Signed-off-by: Ashok Pariya <[email protected]>

kubevirt-bot · 2025-03-26T08:45:19Z

Hi @ashokpariya0. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ashokpariya0 · 2025-03-26T08:45:47Z

cc @oshoval

oshoval · 2025-03-26T08:52:53Z

Nice thanks
interesting that manually i can pull the image
i wonder if we could see the error you pasted in the artifacts?

lets see if @phoracek is fine with this fix, it just means that we might need to change it in the future, but i think we are good to go, it can be stable for lot of time, and once needed we will find out

RamLavi · 2025-03-26T08:57:07Z

/ok-to-test

ashokpariya0 · 2025-03-26T09:24:55Z

i wonder if we could see the error you pasted in the artifacts?

No, I saw the below output files in artifacts , but I don't see the error since the test pod creation itself failed. The error should be available in the kubelet logs and describe output of test pod. Do we collect kubelet logs in case of failure?

ls -lthr
total 24K
-rw-r--r--. 1 root root 1.3K Mar 26 08:23 junit.functest.xml
-rw-r--r--. 1 root root    0 Mar 26 08:23 bridge-marker.log
-rw-r--r--. 1 root root  17K Mar 26 08:23 nodes.yaml

oshoval · 2025-03-26T09:26:29Z

i guess we dont yet, thx

RamLavi · 2025-03-27T06:54:49Z

@ashokpariya0 thank you for this fix, it would do wonders to CNAO tier1 lanes. <3

One question though - since CNAO is consuming bridge-marker main branch on all stable branches - is it OK to consume centos10 on old stable branches?

ashokpariya0 · 2025-03-27T07:14:01Z

@ashokpariya0 thank you for this fix, it would do wonders to CNAO tier1 lanes. <3

One question though - since CNAO is consuming bridge-marker main branch on all stable branches - is it OK to consume centos10 on old stable branches?

I don't see any issue using centos with tag 10, we can use any tag: https://quay.io/repository/centos/centos?tab=tags,
somehow just centos without tag(

bridge-marker/tests/utils.go

Line 139 in 5fb005a

Image: "centos",

) is resulting to ImagePullBackOff ( message: 'reading manifest latest in quay.io/centos: StatusCode: 404, "<!doctype html>\n\n<title>404 Not Foun..."'
reason: ErrImagePull)resulting into test failure,

are we not seeing same failure with bridge-marker test on older stable branch ??

Also, the test(

bridge-marker/tests/marker_test.go

Line 80 in 5fb005a

It("should be started only when bridge is available on node", func() {

) isn't dependent on the specific CentOS image; we just need any pod with a valid image. The pod in the test is created here: Test Pod Creation. You can use any other image for this test

bridge marker test is to verify that a pod, after waiting for the bridge resource to become available, should transition from the "Pending" state to the "Running" state once the Linux bridge is created. The resource requirements for the test are specified as:

resources:
      limits:
        bridge.network.kubevirt.io/br_podtest: "1"
      requests:
        bridge.network.kubevirt.io/br_podtest: "1"

The test ensures that the pod correctly transitions to a running state once the bridge resource is available.

oshoval · 2025-03-27T07:23:44Z

It is a test, not core code fwiw (we can continue discussion offline according needs please)

phoracek

/lgtm

RamLavi · 2025-03-27T09:08:12Z

/approve

kubevirt-bot · 2025-03-27T09:08:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RamLavi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update container image in PodSpec to use centos:10

9b2336e

Changed the container image from "centos" to "centos:10" in the PodSpec function to specify a more specific version of the CentOS image. Signed-off-by: Ashok Pariya <[email protected]>

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 26, 2025

kubevirt-bot requested review from phoracek and RamLavi March 26, 2025 08:45

kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2025

kubevirt-bot added the size/XS label Mar 26, 2025

kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2025

phoracek approved these changes Mar 27, 2025

View reviewed changes

kubevirt-bot assigned phoracek Mar 27, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2025

kubevirt-bot merged commit 144ffa4 into kubevirt:main Mar 27, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update container image in PodSpec to use centos:10 #87

Update container image in PodSpec to use centos:10 #87

Uh oh!

ashokpariya0 commented Mar 26, 2025

Uh oh!

kubevirt-bot commented Mar 26, 2025

Uh oh!

ashokpariya0 commented Mar 26, 2025

Uh oh!

oshoval commented Mar 26, 2025 •

edited

Loading

Uh oh!

RamLavi commented Mar 26, 2025

Uh oh!

ashokpariya0 commented Mar 26, 2025

Uh oh!

oshoval commented Mar 26, 2025

Uh oh!

RamLavi commented Mar 27, 2025 •

edited

Loading

Uh oh!

ashokpariya0 commented Mar 27, 2025 •

edited

Loading

Uh oh!

oshoval commented Mar 27, 2025 •

edited

Loading

Uh oh!

phoracek left a comment

Uh oh!

RamLavi commented Mar 27, 2025

Uh oh!

kubevirt-bot commented Mar 27, 2025

Uh oh!

Uh oh!

Uh oh!

Update container image in PodSpec to use centos:10 #87

Update container image in PodSpec to use centos:10 #87

Uh oh!

Conversation

ashokpariya0 commented Mar 26, 2025

Uh oh!

kubevirt-bot commented Mar 26, 2025

Uh oh!

ashokpariya0 commented Mar 26, 2025

Uh oh!

oshoval commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RamLavi commented Mar 26, 2025

Uh oh!

ashokpariya0 commented Mar 26, 2025

Uh oh!

oshoval commented Mar 26, 2025

Uh oh!

RamLavi commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashokpariya0 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oshoval commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phoracek left a comment

Choose a reason for hiding this comment

Uh oh!

RamLavi commented Mar 27, 2025

Uh oh!

kubevirt-bot commented Mar 27, 2025

Uh oh!

Uh oh!

Uh oh!

oshoval commented Mar 26, 2025 •

edited

Loading

RamLavi commented Mar 27, 2025 •

edited

Loading

ashokpariya0 commented Mar 27, 2025 •

edited

Loading

oshoval commented Mar 27, 2025 •

edited

Loading