Skip to content

Update container image in PodSpec to use ubuntu #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

ashokpariya0
Copy link
Contributor

Changed the container image from "centos" to "ubuntu" in the PodSpec function to specify a more specific version of the CentOS image.

What this PR does / why we need it:

We are encountering an unusual issue with accessing the CentOS image. More details at: kubevirt/cluster-network-addons-operator#2179

Since this test is not dependent on any specific image, we would like to switch from CentOS to Ubuntu in order to get the bridge marker test lane to pass.

For now, we will proceed with the Ubuntu image, which is 73.8 MB in size.

Meanwhile, we can investigate the issue with accessing the CentOS image in parallel.

Special notes for your reviewer:

Release note:

None

Changed the container image from "centos" to "ubuntu" in the PodSpec function
to specify a more specific version of the CentOS image.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2025
@kubevirt-bot
Copy link

Hi @ashokpariya0. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@oshoval
Copy link
Collaborator

oshoval commented Mar 27, 2025

/retest
EDIT - ah oops it was already running

@oshoval
Copy link
Collaborator

oshoval commented Mar 27, 2025

@phoracek can you review please?

@RamLavi
Copy link
Collaborator

RamLavi commented Mar 27, 2025

/ok-to-test
/approve

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2025
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2025
@kubevirt-bot kubevirt-bot merged commit 4002ef9 into kubevirt:main Mar 27, 2025
4 checks passed
@RamLavi
Copy link
Collaborator

RamLavi commented Mar 27, 2025

checking solution manually via CNAO kubevirt/cluster-network-addons-operator#2186

@ashokpariya0
Copy link
Contributor Author

it seems bridge marker test lane passed finally now :)

https://prow.ci.kubevirt.io/log?container=test&id=1905234905827119104&job=pull-e2e-cluster-network-addons-operator-br-marker-functests

JUnit report was created: /logs/artifacts/junit.functest.xml

Ran 2 of 2 Specs in 220.073 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped

@oshoval
Copy link
Collaborator

oshoval commented Mar 27, 2025

awesome, can you please create a bm release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants