Skip to content

cmd, manifests: Add readiness and lifeness probes #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented May 13, 2025

What this PR does / why we need it:
Add readiness and lifeness probes to adhere to k8s controller best practices

Release note:

Add readiness and lifeness probes

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 13, 2025
@kubevirt-bot kubevirt-bot requested review from phoracek and RamLavi May 13, 2025 09:25
@qinqon qinqon force-pushed the operator-best-practices-add-probes branch from b2100b7 to bc949db Compare May 13, 2025 09:40
Copy link

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@phoracek
Copy link
Member

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@kubevirt-bot kubevirt-bot merged commit 5701f69 into kubevirt:main May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants