Support KubevirtIpamController plugin #1808
Conversation
kubevirt-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
the
dco-signoff: yes
oshoval
force-pushed
the
ipam
branch
13 times, most recently
from
c200262
to
f1f44b0
Compare
oshoval
changed the title
|
/test pull-e2e-cluster-network-addons-operator-lifecycle-k8s |
|
/test pull-e2e-cnao-kube-secondary-dns-functests locally it doesnt fail, just on CI |
|
/test pull-e2e-cluster-network-addons-operator-workflow-k8s |
|
|
/approve Thanks |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/override pull-e2e-cluster-network-addons-operator-workflow-k8s happens on clean main as well |
|
@oshoval: Overrode contexts on behalf of oshoval: pull-e2e-cluster-network-addons-operator-workflow-k8s In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold need to fix lifecycle by deploying cert-manager as it has different flow from glance |
kubevirt-bot
added
the
do-not-merge/hold
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel checked that all passed on CI on other PR had to move the cert-manager install as part of cluster-up since also lifecycle needs it |
kubevirt-bot
removed
the
do-not-merge/hold
|
/lgtm (got 2 lgtms before, and this change is small) |
|
@oshoval: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Or Shoval <[email protected]>
Without it, we don't have memory to create some virtual machines (saw it for example on KSD lane). Signed-off-by: Or Shoval <[email protected]>
Since we introduce a non kubevirtci cluster, refactor the script to allow code reuse while using both types of clusters. All current lanes are agnostic for the change. Signed-off-by: Or Shoval <[email protected]>
Signed-off-by: Or Shoval <[email protected]>
|
just changed readme |
|
/override pull-e2e-cluster-network-addons-operator-workflow-k8s fails also on clean main |
|
@oshoval: Overrode contexts on behalf of oshoval: pull-e2e-cluster-network-addons-operator-workflow-k8s In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - name: Set up Go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version-file: 'go.mod' |
There was a problem hiding this comment.
btw this is tricky
it takes the one from CNAO's go.mod
and use it as the go version for OVN-K as well
for now it works, it might break in the future and then we will take care about it
What this PR does / why we need it:
Integrate https://github.com/maiqueb/kubevirt-ipam-claims as CNAO component.
Allows to support IPAM for user defined networks.
Deployment was tested manually on KCLI Openshift cluster.
Special notes for your reviewer:
CRD will be deployed only U/S, on D/S it is deployed by Openshift CNO.
On Openshift, we are using the cert manager that is already deployed,
on upstream the user should install a cert library (done at
cluster-upfor convenience).The new lane is using github actions, OVN-K8s kind.sh helper script to create the cluster.
It includes Multus so Multus is not deployed by CNAO on that lane.
Release note: