Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kubevirt-ipam-controller to v0.1.6-alpha #1874

Merged

Conversation

kubevirt-bot
Copy link
Collaborator

bump kubevirt-ipam-controller to v0.1.6-alpha
Executed by Bumper script

bump kubevirt-ipam-controller to v0.1.6-alpha

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 19, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@oshoval
Copy link
Collaborator

oshoval commented Aug 19, 2024

need to fix the double run of ipam here
(also HashiCorp has same problem)
Seems it happens when the bot trigger it, but not when a user created a PR
#1867

PR #1875 (WIP)

@kubevirt-bot kubevirt-bot merged commit bf9af95 into main Aug 19, 2024
18 checks passed
@oshoval
Copy link
Collaborator

oshoval commented Aug 19, 2024

Hi @maiqueb
Please note this PR made CNAO include kubevirt/ipam-extensions#52 on main branch,
but not for CNAO release 0.95.0, since now it has its own branch.
If you think we need it for the upcoming CF, we would need to cherry-pick it to the branch (of course to first make sure we can if CF date passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants