-
Notifications
You must be signed in to change notification settings - Fork 304
bazel-build-images: adapt script to rules_oci #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Before this pr I got error as below after running make all
ERROR: Skipping '//:test-container-images': no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
INFO: Elapsed time: 0.084s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
make: *** [Makefile:192: bazel-build-images] Error 1
After applying this patch, the error is gone, hope this PR can be merged soon 🎉
hack/build/bazel-build-images.sh
Outdated
| "cdi-func-test-bad-webserver" | ||
| "cdi-func-test-proxy" | ||
| "cdi-func-test-sample-populator" | ||
| "cdi-func-test-file-host-init" | ||
| "cdi-func-test-file-host-http" | ||
| "cdi-func-test-registry-init" | ||
| "cdi-func-test-tinycore" | ||
| "cdi-func-test-registry-populate" | ||
| "cdi-func-test-registry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: in other sh files (e.g. bazel-push-images.sh, build-copy-artifacts.sh .etc.) we use 4 space indention, could you please align the indention in this file? thanks!
|
@brandboat: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The move from rules_docker to rules_oci removed the test images container_bundle rule but the bazel-build-images script wasn't updated to adapt to that change. This commit fixes that. Signed-off-by: Adi Aloni <[email protected]>
21e138f to
c8b8427
Compare
|
@Acedus: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
The move from rules_docker to rules_oci removed the test images container_bundle rule but the bazel-build-images script wasn't updated to adapt to that change. This commit fixes that.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: