Skip to content

Conversation

@Acedus
Copy link
Contributor

@Acedus Acedus commented Jan 5, 2026

What this PR does / why we need it:
The move from rules_docker to rules_oci removed the test images container_bundle rule but the bazel-build-images script wasn't updated to adapt to that change. This commit fixes that.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Jan 5, 2026
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mhenriks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jan 5, 2026

Coverage Status

coverage: 49.442% (+0.05%) from 49.388%
when pulling c8b8427 on Acedus:fix-bazel-build-images
into c5480cc on kubevirt:main.

Copy link

@brandboat brandboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Before this pr I got error as below after running make all

ERROR: Skipping '//:test-container-images': no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
INFO: Elapsed time: 0.084s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
make: *** [Makefile:192: bazel-build-images] Error 1

After applying this patch, the error is gone, hope this PR can be merged soon 🎉

Comment on lines 45 to 53
"cdi-func-test-bad-webserver"
"cdi-func-test-proxy"
"cdi-func-test-sample-populator"
"cdi-func-test-file-host-init"
"cdi-func-test-file-host-http"
"cdi-func-test-registry-init"
"cdi-func-test-tinycore"
"cdi-func-test-registry-populate"
"cdi-func-test-registry"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in other sh files (e.g. bazel-push-images.sh, build-copy-artifacts.sh .etc.) we use 4 space indention, could you please align the indention in this file? thanks!

@kubevirt-bot
Copy link
Contributor

@brandboat: changing LGTM is restricted to collaborators

Details

In response to this:

LGTM, thanks!

Before this pr I got error as below after ran make all

ERROR: Skipping '//:test-container-images': no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//:test-container-images': target 'test-container-images' not declared in package '' defined by /root/go/src/kubevirt.io/containerized-data-importer/BUILD.bazel (Tip: use `query "//:*"` to see all the targets in that package)
INFO: Elapsed time: 0.084s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
make: *** [Makefile:192: bazel-build-images] Error 1

After applying this patch, the error is gone, hope this PR can be merged soon 🎉

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The move from rules_docker to rules_oci removed the test images
container_bundle rule but the bazel-build-images script wasn't updated
to adapt to that change. This commit fixes that.

Signed-off-by: Adi Aloni <[email protected]>
@Acedus Acedus force-pushed the fix-bazel-build-images branch from 21e138f to c8b8427 Compare January 7, 2026 07:45
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 7, 2026

@Acedus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-generate-verify c8b8427 link true /test pull-cdi-generate-verify
pull-cdi-apidocs c8b8427 link true /test pull-cdi-apidocs
pull-containerized-data-importer-e2e-destructive c8b8427 link true /test pull-containerized-data-importer-e2e-destructive
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants