Skip to content

Conversation

@akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Jan 11, 2026

What this PR does / why we need it:
Some provisioners (trident nfs) have a weird status.restoresize
which may direct users towards using a wrong disk restore size.

Expose our own advised size in the annotations.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Enhancement: Expose advised restore size for cron snapshot sources cdi.kubevirt.io/storage.import.advisedRestoreSize

Some provisioners (trident nfs) have a weird restoresize
which may direct users towards using a wrong disk restore size.

Expose our own advised size in the annotations.

Signed-off-by: Alex Kalenyuk <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jan 11, 2026
@kubevirt-bot kubevirt-bot requested review from aglitke and awels January 11, 2026 18:41
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

coverage: 49.444% (+0.06%) from 49.388%
when pulling 11cf29d on akalenyu:restore-size-hint
into c5480cc on kubevirt:main.

@akalenyu
Copy link
Collaborator Author

/retest
don't think they're related

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants