WIP: Add support for OpenShift console on native Kubernetes #2996

AaronDewes · 2024-06-11T08:32:43Z

What this PR does / why we need it:

OpenShift's console can be run on standard Kubernetes. This adds support for the console integration in such scenarios.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

NONE

Release note:

Integrate with the OpenShift console for regular Kubernetes systems.

kubevirt-bot · 2024-06-11T08:32:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign assafad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2024-06-11T08:32:52Z

Hi @AaronDewes. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-06-11T08:32:54Z

Hi @AaronDewes. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Aaron Dewes <[email protected]>

sonarcloud · 2024-06-14T08:07:31Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kubevirt-bot · 2024-06-14T14:12:13Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nunnatsa

Thanks for the PR @AaronDewes. It makes a lot of sense to me.

Added a few inline comments.

nunnatsa · 2024-06-16T05:50:29Z

pkg/util/cluster.go

 			c.logger.Info("Cluster type = kubernetes")
+			c.runningWithOpenshiftConsole = isCRDExists(ctx, cl, OpenShiftConsolePluginCRDName)


Is that enough? Shouldn't we also check that the CR also exists?

The OpenShiftConsolePlugin custom resource allows us to register a console plugin. I don't think we need to check if any CR exists as long as the CRD exists.

pkg/util/cluster.go

nunnatsa · 2024-06-16T05:53:34Z

pkg/util/cluster.go

@@ -43,7 +44,8 @@ type ClusterInfo interface {
 }

 type ClusterInfoImp struct {
-	runningInOpenshift            bool
+	runningInNativeOpenshift      bool


I wouldn't change the name of this field. We want to know if HCO is running in an openshift cluster or not, and this the old name is accurate. Also, I don't know what "native openshift" means.

Yes, I'll revert the name change 👍

nunnatsa · 2024-06-16T05:55:09Z

pkg/util/cluster.go

@@ -43,7 +44,8 @@ type ClusterInfo interface {
 }

 type ClusterInfoImp struct {
-	runningInOpenshift            bool
+	runningInNativeOpenshift      bool
+	runningWithOpenshiftConsole   bool


HCO and the openshift console are not actually related. so it's not like HCO is running with the console. What do you think about something like openshiftConsoleInstalled?

nunnatsa · 2024-06-16T05:56:21Z

pkg/util/cluster.go

+	return c.runningInNativeOpenshift
+}
+
+func (c *ClusterInfoImp) HasOpenshiftConsole() bool {


same: How do you feel about something like IsOpenshifConsoleInstalled()?

nunnatsa · 2024-06-16T06:04:01Z

controllers/operands/operandHandler.go

@@ -59,16 +59,19 @@ func NewOperandHandler(client client.Client, scheme *runtime.Scheme, ci hcoutil.
 		newAAQHandler(client, scheme),
 	}

-	if ci.IsOpenshift() {
+	if ci.HasOpenshiftConsole() {


not sure about this whole logic. @tiraboschi - WDYT?

I don't think that the SSP operator (line 64) will work on vanially k8s just because the Openshift Console has been deployed there.

kubevirt-bot · 2024-09-16T07:58:09Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot · 2024-10-16T08:04:32Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot requested review from avlitman and machadovilaca June 11, 2024 08:32

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2024

kubevirt-bot added the size/L label Jun 11, 2024

WIP: Add support for OpenShift console on native Kubernetes

63bebed

Signed-off-by: Aaron Dewes <[email protected]>

AaronDewes force-pushed the openshift-console branch from 03e9b92 to 63bebed Compare June 14, 2024 08:07

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 14, 2024

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2024

nunnatsa reviewed Jun 16, 2024

View reviewed changes

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024

kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add support for OpenShift console on native Kubernetes #2996

WIP: Add support for OpenShift console on native Kubernetes #2996

AaronDewes commented Jun 11, 2024

kubevirt-bot commented Jun 11, 2024

kubevirt-bot commented Jun 11, 2024

openshift-ci bot commented Jun 11, 2024

sonarcloud bot commented Jun 14, 2024

kubevirt-bot commented Jun 14, 2024

nunnatsa left a comment

nunnatsa Jun 16, 2024

AaronDewes Jun 16, 2024

nunnatsa Jun 16, 2024

AaronDewes Jun 16, 2024

nunnatsa Jun 16, 2024

nunnatsa Jun 16, 2024

nunnatsa Jun 16, 2024

tiraboschi Jun 18, 2024

kubevirt-bot commented Sep 16, 2024

kubevirt-bot commented Oct 16, 2024

		c.logger.Info("Cluster type = kubernetes")
		c.runningWithOpenshiftConsole = isCRDExists(ctx, cl, OpenShiftConsolePluginCRDName)

WIP: Add support for OpenShift console on native Kubernetes #2996

Are you sure you want to change the base?

WIP: Add support for OpenShift console on native Kubernetes #2996

Conversation

AaronDewes commented Jun 11, 2024

kubevirt-bot commented Jun 11, 2024

kubevirt-bot commented Jun 11, 2024

openshift-ci bot commented Jun 11, 2024

sonarcloud bot commented Jun 14, 2024

Quality Gate passed

kubevirt-bot commented Jun 14, 2024

nunnatsa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubevirt-bot commented Sep 16, 2024

kubevirt-bot commented Oct 16, 2024