.github/workflows/golang.yaml

Add controller logic #1

Sign in to view logs

Triggered via pull request April 15, 2024 11:11

maiqueb

opened #2

add-controller-logic

Status Failure

Total duration 1m 43s

Artifacts –

golang.yaml

on: pull_request

build-linters-unit-tests

Annotations

10 errors and 1 warning

build-linters-unit-tests: pkg/vmnetworkscontroller/controller.go#L7

File is not `goimports`-ed (goimports)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller.go#L50

line is 136 characters (lll)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller.go#L72

line is 134 characters (lll)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller_test.go#L183

line is 154 characters (lll)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller_test.go#L347

Consider pre-allocating `ipamClaimsSpec` (prealloc)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller_test.go#L277

`dummyVM` - `nadName` always receives `nadName` (`"ns1/superdupernad"`) (unparam)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller_test.go#L291

`dummyVMI` - `nadName` always receives `nadName` (`"ns1/superdupernad"`) (unparam)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller_test.go#L320

`dummyNAD` - `nadName` always receives `nadName` (`"ns1/superdupernad"`) (unparam)

build-linters-unit-tests: cmd/main.go#L90

ineffectual assignment to tlsOpts (ineffassign)

build-linters-unit-tests: pkg/vmnetworkscontroller/controller.go#L102

SA4031: this nil check is always true (staticcheck)

build-linters-unit-tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.